Skip to content

Commit

Permalink
fix(toolchain): Fix toolchain manager not showing pre-prelease toolch…
Browse files Browse the repository at this point in the history
…ains

Co-authored-by: MarkoSagadin <[email protected]>
  • Loading branch information
TjazVracko and MarkoSagadin committed Nov 7, 2024
1 parent 97434dc commit 6ba200d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased]

### Added

- Support for installing non-release NCS versions of toolchain, such as `v2.7.0-rc1`. East will
now correctly install such versions of the toolchain, if found in the west manifest file.

### Fixed

- A bug in `east build` parsing introduced in v0.23.2.
Expand Down
2 changes: 1 addition & 1 deletion src/east/east_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ def pre_workspace_command_check(
return

# Check if toolchain for detected ncs version is supported
result = self.run_manager("search", silent=True, return_output=True)
result = self.run_manager("search --show-all", silent=True, return_output=True)

if self.detected_ncs_version in result["output"]:
# Supported but not installed, should we exit program or silently pass?
Expand Down

0 comments on commit 6ba200d

Please sign in to comment.