Skip to content

update to httr2#143

Open
christopherkenny wants to merge 2 commits intoIQSS:mainfrom
christopherkenny:main
Open

update to httr2#143
christopherkenny wants to merge 2 commits intoIQSS:mainfrom
christopherkenny:main

Conversation

@christopherkenny
Copy link

@christopherkenny christopherkenny commented Feb 27, 2026

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

Note: I have not edited the tests, as there are no new features, just internal changes, but the existing tests pass.

addresses #142

@pdurbin
Copy link
Member

pdurbin commented Mar 4, 2026

@christopherkenny hi! If you want this PR to close that issue you should change "addresses" to "closes" (or another keyword). But only if you do! Thanks for the PR! ❤️

@kuriwaki kuriwaki self-assigned this Mar 4, 2026
@kuriwaki kuriwaki linked an issue Mar 4, 2026 that may be closed by this pull request
@kuriwaki
Copy link
Member

kuriwaki commented Mar 4, 2026

Great -- I went ahead and made the attribution myself. Will try it out.

@christopherkenny
Copy link
Author

Thanks @pdurbin. Appreciate the tip. And thanks, Shiro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update internally to httr2

3 participants