delete ionosmail on ncmail deletion #19
Conversation
printminion-co
force-pushed
the
mk/dev/delete_ionosmail_on_ncmail_deletion
branch
6 times, most recently
from
4bc87fc to
7a12f7a
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements automatic deletion of IONOS mailboxes when their corresponding Nextcloud Mail accounts are deleted. The implementation introduces a new service to handle the deletion logic with proper validation to ensure only legitimate IONOS-provisioned accounts are deleted.
Key Changes:
- Added
IonosAccountDeletionServiceto orchestrate the deletion workflow with domain and email verification - Implemented
getIonosEmailForUser()method inIonosMailServiceto retrieve provisioned email addresses - Integrated the deletion service into
AccountServiceto hook into the account deletion flow
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/Service/IONOS/IonosAccountDeletionService.php | New service implementing validated IONOS mailbox deletion logic |
| lib/Service/IONOS/IonosMailService.php | Added method to retrieve IONOS provisioned email for a user |
| lib/Service/AccountService.php | Integrated IONOS deletion service into account deletion workflow |
| tests/Unit/Service/IONOS/IonosAccountDeletionServiceTest.php | Comprehensive test coverage for deletion service scenarios |
| tests/Unit/Service/IONOS/IonosMailServiceTest.php | Tests for new email retrieval functionality |
| tests/Unit/Service/AccountServiceTest.php | Updated tests to verify deletion service integration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
printminion-co
force-pushed
the
mk/dev/delete_ionosmail_on_ncmail_deletion
branch
from
7a12f7a to
0793129
Compare
…mail account retrieval Improves clarity of error logging by specifying the context of IONOS mail account retrieval failures. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
…and logging - Refactored mail account existence check to return MailAccountResponse instead of boolean. - Enhanced logging messages for better clarity during account retrieval. - Introduced a private method to encapsulate the logic for fetching the mail account response. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/delete_ionosmail_on_ncmail_deletion
branch
from
0793129 to
fc8e330
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
printminion-co
force-pushed
the
mk/dev/delete_ionosmail_on_ncmail_deletion
branch
from
fc8e330 to
6171aaa
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… mail account deletion Add IonosAccountDeletionService to handle the deletion of IONOS mailboxes when associated mail accounts are deleted. This service checks if the account is an IONOS account and safely deletes the mailbox while logging relevant information. Integration checks are included to prevent accidental deletions. Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
force-pushed
the
mk/dev/delete_ionosmail_on_ncmail_deletion
branch
from
6171aaa to
513b08e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
based on #17