Create a cli package for Services by 8ohamed · Pull Request #1377 · INTO-CPS-Association/DTaaS

8ohamed · 2025-12-05T14:04:07Z

Create a cli poetry package for managing services

Type of Change

New feature

Description

This PR solves the #1375 issue, by creating a poetry cli package, so the user can manage the platform services by entring command lines.

…ture/distributed-demo

…/DTaaS into feature/distributed-demo

Copilot

Pull request overview

Copilot reviewed 41 out of 52 changed files in this pull request and generated no new comments.

prasadtalasila · 2026-01-03T19:33:20Z

@8ohamed please skip the updating of code outside of deploy/services/cli. Let us focus on getting this PR done.

8ohamed · 2026-01-04T13:33:10Z

@8ohamed please skip the updating of code outside of deploy/services/cli. Let us focus on getting this PR done.

@prasadtalasila Should I revert the changes in the top cli, and wait for you to merge this PR, then in a different PR I commit the changes for the top cli.

prasadtalasila · 2026-01-04T15:10:32Z

@8ohamed please refer the changes in the top-level cli. Thanks.

Copilot

Pull request overview

Copilot reviewed 40 out of 51 changed files in this pull request and generated no new comments.

8ohamed · 2026-01-05T17:15:10Z

Hi @prasadtalasila I updated the stop command it should fix the status command. if not I will look into it again in the next PR.

prasadtalasila · 2026-01-05T18:12:39Z

@8ohamed are the qlty issues fixed as well?

8ohamed · 2026-01-05T18:14:40Z

@prasadtalasila yes in "a646ea0"

Copilot

Pull request overview

Copilot reviewed 40 out of 51 changed files in this pull request and generated 1 comment.

deploy/services/cli/dtaas_services/pkg/service.py

Copilot

Pull request overview

Copilot reviewed 40 out of 51 changed files in this pull request and generated 1 comment.

Copilot · 2026-01-06T20:48:20Z

deploy/services/cli/tests/test_service.py

@@ -0,0 +1,432 @@
+# pylint: disable=redefined-outer-name
+"""Tests for Service class and Docker operations"""
+import os


Import of 'os' is not used.

prasadtalasila · 2026-01-08T08:36:28Z

@8ohamed There are still eleven qlty issues in the deploy/services/cli. Are you still working on them? Thanks for clarification.

Copilot

Pull request overview

Copilot reviewed 40 out of 51 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 40 out of 51 changed files in this pull request and generated no new comments.

8ohamed · 2026-01-08T14:25:25Z

Hi @prasadtalasila I fixed the qlty issues, if you inspect qlty.sh on the repo it might still say that some files has 1 or 2 issues, but if you enter the file it doesn't show any issues, I think it takes more time to update the values.

And here's the output of the commands on the server

sonarqubecloud · 2026-01-08T17:20:59Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

Copilot reviewed 40 out of 51 changed files in this pull request and generated 1 comment.

Copilot · 2026-01-08T17:22:56Z

deploy/services/cli/README.md

+ensure you run the setup command with appropriate privileges:
+
+```bash
+sudo -E env PATH="$PATH" dtaas-services setup


The recommended command sudo -E env PATH="$PATH" dtaas-services setup preserves the unprivileged user’s PATH when escalating to root, which can allow execution of attacker-controlled binaries as root if a writable directory (e.g. $HOME/bin) appears early in PATH. An attacker who can modify a directory on the user’s PATH could place a malicious docker or other executable that the CLI or its dependencies invoke, leading to local privilege escalation and full compromise of the host. To mitigate this, avoid preserving the full user PATH for privileged runs and rely on a minimal, root-controlled PATH when invoking dtaas-services with elevated privileges.

Suggested change

sudo -E env PATH="$PATH" dtaas-services setup

sudo dtaas-services setup

8ohamed added 30 commits November 16, 2025 17:00

Define resource limits, and adds tests in test_config

6c13134

test utils updated

8968d0c

added limits to compose files

71a6250

added cpuset + resolved issues

3e91a9e

test issue

337b661

removed cpuset

ae7a39e

remove cpuset

72a0dff

applies snake_case to tests

1166023

resolves sonar issues

a9311a6

minor updates

a34b554

update pid limit in compose

819e502

changed pids_limit back

9b15119

initial commit

d4e99f0

Merge branch 'INTO-CPS-Association:feature/distributed-demo' into fea…

9a2c8cf

…ture/distributed-demo

test issue

5d12713

applies snake_case to tests

b9abf46

resolves sonar issues

ce3ff7e

minor updates

f2efa23

update pid limit in compose

47f3885

changed pids_limit back

8e87d19

initial commit

f6cc63a

Merge branch 'feature/distributed-demo' of https://github.com/8ohamed…

5d15586

…/DTaaS into feature/distributed-demo

minor fix

d76b287

removed user arg

6595acf

refactors service_setup, updates readme

3b4f545

applies coding suggestions

0380b11

Handles windows OS

1317cc9

applying suggestions

3542676

applying suggestions

4c9587f

minor updates

dc2e4a5

fixes pylint warning

0026324

Copilot AI reviewed Jan 3, 2026

View reviewed changes

fixing pylint issues at the top cli tests

d96dd1f

revert changes in top level cli

84224fe

Copilot AI reviewed Jan 4, 2026

View reviewed changes

fixes the get_status command

ea31b71

ensuring Compose project name

fb8069e

Copilot AI reviewed Jan 6, 2026

View reviewed changes

deploy/services/cli/dtaas_services/pkg/service.py Outdated Show resolved Hide resolved

8ohamed added 2 commits January 6, 2026 21:17

qlty issues

01b2a20

qlty fixes in service.py

733d99d

Copilot AI reviewed Jan 6, 2026

View reviewed changes

qlty issues

c7aa571

qlty issues

9c66e41

Copilot AI reviewed Jan 8, 2026

View reviewed changes

8ohamed added 2 commits January 8, 2026 14:44

minor fix

fa07324

minor fix

c091bb8

Copilot AI reviewed Jan 8, 2026

View reviewed changes

minor fix

808ac46

small refactor

821efbc

Copilot AI reviewed Jan 8, 2026

View reviewed changes

prasadtalasila mentioned this pull request Jan 9, 2026

[FEATURE]Create poetry project for services #1375

Closed

3 tasks

	sudo -E env PATH="$PATH" dtaas-services setup
	sudo dtaas-services setup

Conversation

8ohamed commented Dec 5, 2025

Create a cli poetry package for managing services

Type of Change

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

prasadtalasila commented Jan 3, 2026

Uh oh!

8ohamed commented Jan 4, 2026

Uh oh!

prasadtalasila commented Jan 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

8ohamed commented Jan 5, 2026

Uh oh!

prasadtalasila commented Jan 5, 2026

Uh oh!

8ohamed commented Jan 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

prasadtalasila commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

8ohamed commented Jan 8, 2026

Uh oh!

sonarqubecloud bot commented Jan 8, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants