Skip to content

repo amelie-renan-nathan#9

Open
nathanwallerick wants to merge 12 commits intoINSAlgo:mainfrom
capucine-bois:amelie-renan-nathan
Open

repo amelie-renan-nathan#9
nathanwallerick wants to merge 12 commits intoINSAlgo:mainfrom
capucine-bois:amelie-renan-nathan

Conversation

@nathanwallerick
Copy link

Voilà c'est le TP

Copilot AI review requested due to automatic review settings December 11, 2025 13:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request contains submission materials for a Git workshop (TP Git), including new Python exercise files and documentation updates. The PR is from a team of three students (Amélie, Renan, and Nathan) completing practical Git exercises.

Key changes:

  • Addition of two Python exercise files demonstrating basic functions and Git workflow
  • Comprehensive update to README.md modernizing installation instructions and exercise details for 2025
  • Modification to NOMS.txt file removing several names

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.

File Description
amelie-renan-nathan/helloworld.py Simple Hello World program to demonstrate basic Git operations
amelie-renan-nathan/fonctions.py Math functions and team member display for collaborative Git exercises
README.md Extensive modernization of Git workshop instructions, adding detailed installation guides and clearer exercise structure
NOMS.txt Removal of four names (Alix, Romain, Gaspard, Ewan) from the participant list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


def addition(x, y):
"""Retourne la somme de x et y"""
return a+b
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function parameters are named x and y, but the return statement uses undefined variables a and b. This will cause a NameError at runtime. The return statement should use the parameter names that match the function signature.

Suggested change
return a+b
return x + y

Copilot uses AI. Check for mistakes.
Comment on lines 1 to 2
Capucine
Rahul
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of names (Alix, Romain, Gaspard, Ewan) from the NOMS.txt file appears unintentional or problematic. According to the TP instructions in the README, each team should add their names to this file without removing others. This change removes data that should likely be preserved for other teams.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants