Conversation
…nd homogen.sos-map) by not adding unneccassary device base position and by fixing dtype error of delays container
…ng of speed_of_sound
…spect to analytical solution for horizontal gradient)
…st neighbour values and not to linearly interpolate
…et bugs in the interpolation, temporary added memory debug prints in order to change function with own interpolation to reduce memory needed (so far the hDASToySoS test does not run with the new function due to out of memory error)
…memory_stats function for printing used memory
…elays with analytically integrated delays
IMPORTANT: noticed that sensor_positions were globally overwritten --> now copy
improved comments
… scipy interpolation
…he PAI-realistic units
made input of scalarfield-type more user friendly
grid_points_middle verbose get_interpols uneven_steps global_ds_calc
also deleted unnecessary speed_of_sound_in_m_per_s input in compute image dimensions
float64 in source positions due to detected inaccuracies
fixed bug in sensor positions initializtation (z-components to 0) vectorized analytical solution
# Conflicts: # simpa/core/simulation_modules/reconstruction_module/reconstruction_utils.py
improved plotting and added critical sensor computation
removed print_memory_stats corrected hDAS tissue (heterogenous DAS is now calculated using the mean sos value not a fixed one)
Collaborator
Author
|
Code is ready for review |
Collaborator
|
Were there any additional changes that need to be updated? |
Collaborator
|
Hi @cbender98, I just noticed that this has been untouched since your initial commit 3 years ago - if you think it is worth the time, I am happy to look into it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Changes:
Note:
Branch was really old (48 commits behind) --> a lot of merge conflicts