2821 hi l1c use hi goodtimes in pset processing

[subagonsouth]

Summary

This PR integrates goodtimes filtering into the Hi L1C PSET algorithm. Events and exposure time clock ticks that fall within "bad" times (as identified by the goodtimes product) are now excluded from the L1C counts and exposure time calculations.

Changes

imap_processing/hi/hi_l1c.py

• Added goodtimes_ds parameter to hi_l1c(), generate_pset_dataset(), pset_counts(), and pset_exposure() functions
• Implemented good_time_and_phase_mask() function that filters events/clock ticks based on the goodtimes cull_flags array:
  • Uses nominal_bin (spacecraft spin phase bins 0-89) to look up cull_flags
  • Maps METs to goodtimes intervals using np.searchsorted
  • Returns boolean mask where True = good time (cull_flags == 0)
• Updated pset_exposure() to compute spacecraft spin phase first, then derive instrument spin phase from it. This allows reusing the spacecraft spin phase for both goodtimes filtering and instrument spin phase calculation without redundant SPICE queries.

imap_processing/cli.py

• Updated Hi L1C PSET processing to load the goodtimes dependency
• Renamed science_paths to l1b_de_paths for clarity
• Added validation that exactly one goodtimes file is provided

imap_processing/tests/hi/test_hi_l1c.py

• Added fixtures hi_l1b_de_dataset and hi_goodtimes_dataset to reduce code duplication
• Added test_pset_exposure_goodtimes_filtering - verifies exposure time properly excludes clock ticks in bad times
• Added test_pset_counts_goodtimes_filtering - verifies counts properly exclude events in bad times
• Added TestGoodTimeAndPhaseMask test class with tests for the filtering logic
• Updated existing tests to use the new fixtures and pass goodtimes datasets

Closes: #2821

[Copilot]

Pull request overview

Integrates Hi L1B goodtimes culling into the Hi L1C PSET pipeline so that DE counts and exposure time exclude events/clock ticks that fall in bad-time intervals.

Changes:

• Threaded a goodtimes_ds dependency through Hi L1C PSET generation and added good_time_and_phase_mask() for filtering using cull_flags.
• Updated CLI Hi L1C PSET processing to require/load a goodtimes dependency and tightened dependency validation.
• Expanded/updated unit tests and external-data tests to cover goodtimes filtering behavior and reduce fixture duplication.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
imap_processing/hi/hi_l1c.py	Adds goodtimes-aware filtering for PSET counts/exposure and introduces good_time_and_phase_mask() based on cull_flags.
imap_processing/cli.py	Loads/validates goodtimes as an explicit dependency for Hi L1C PSET processing.
imap_processing/tests/hi/test_hi_l1c.py	Adds fixtures and new tests verifying goodtimes filtering in counts/exposure and mask logic.
imap_processing/tests/test_cli.py	Updates CLI test inputs for Hi L1C PSET to include the goodtimes dependency.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.