Glows time flags#2819
Open
laspsandoval wants to merge 11 commits intoIMAP-Science-Operations-Center:devfrom
Open
Glows time flags#2819laspsandoval wants to merge 11 commits intoIMAP-Science-Operations-Center:devfrom
laspsandoval wants to merge 11 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
added 3 commits
March 6, 2026 14:35
Contributor
Author
|
There are two flags that we not well-defined in the Algorithm Document that I will need to come back to: flag based on comparison of the total numbers of counts in a given block-accumulated histogram with the external information on exceeding a background threshold (TBC) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the GLOWS L1B data processing pipeline, focusing on more accurate computation and testing of histogram bad-time flags. The main changes include implementing a new
compute_flagsmethod forHistogramL1B, updating test data and test cases to align with the new flag logic, and adding utility functions for threshold extraction.Enhancements to flag computation and logic:
compute_flagsmethod to theHistogramL1Bclass to compute the 17 bad-time flags based on onboard and ground processing logic, using thresholds fromPipelineSettings. This replaces the previous approach of setting all flags to 1 and introduces more granular checks for temperature, voltage, spin period, and pulse length standard deviations.__post_init__method ofHistogramL1Bto use the newcompute_flagsmethod for initializing theflagsattribute, ensuring flags are computed correctly at object creation.Utility and helper functions:
get_thresholdfunction to extract threshold values from nested dictionaries based on suffix matching, used in flag computation.Testing improvements:
mock_pipeline_settingsfixture to provide realistic flag values, reflecting the new flag computation logic.test_process_histogramand added a newtest_compute_flagstest to validate the new flag computation, including cases where threshold values are exceeded and flags are set to bad. [1] [2]get_thresholdfunction to ensure correct extraction of threshold values from the settings dictionary.These changes collectively improve the accuracy, maintainability, and test coverage of the GLOWS L1B data processing pipeline.