Repository navigation
Avoid explicit requirement of .0 on whole numbers of seconds - #722
Merged
Merged
Conversation
tomcrane
requested review from
glenrobson,
robcast and
triplingual
and removed request for
glenrobson and
triplingual
September 23, 2026 10:55
mikeapp
approved these changes
Sep 23, 2026
robcast
approved these changes
Sep 23, 2026
robcast
left a comment
robcast
left a comment
Contributor
There was a problem hiding this comment.
looks good. (I think the JSON spec not further distinguishing number is the strongest argument :-)
glenrobson
approved these changes
Oct 2, 2026
glenrobson
added
the
meta: ready-to-merge
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partner to IIIF/api#2495
Addresses IIIF/api#2492
We don't need people to explicitly "type" their
durationvalues to floating point numbers by adding a redundant.0where th value happens to be a whole number. It's just a number.