Skip to content

style: plh_kids_teens_za theme updates#3142

Open
jfmcquade wants to merge 7 commits intomasterfrom
style/plh-kids-teens-za-theme-updates
Open

style: plh_kids_teens_za theme updates#3142
jfmcquade wants to merge 7 commits intomasterfrom
style/plh-kids-teens-za-theme-updates

Conversation

@jfmcquade
Copy link
Copy Markdown
Collaborator

@jfmcquade jfmcquade commented Sep 12, 2025

PR Checklist

Description

Updates to the plh_kids_teens_za theme that were originally included as part of #3140. Having them in a separate PR here lets us test and iterate.

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

@jfmcquade jfmcquade changed the base branch from master to 3139-plh_kids_teens_za-theme September 12, 2025 16:16
@jfmcquade jfmcquade changed the base branch from 3139-plh_kids_teens_za-theme to master September 12, 2025 16:17
@jfmcquade jfmcquade changed the base branch from master to 3139-plh_kids_teens_za-theme September 12, 2025 16:17
@jfmcquade jfmcquade marked this pull request as ready for review September 12, 2025 16:29
Base automatically changed from 3139-plh_kids_teens_za-theme to master September 12, 2025 16:38
Copy link
Copy Markdown
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description master PR branch
button and header colour look strange together image image
plh_module_item colours have disappeared image image
radio button grid background colour has too little contrast with yellow emojis (not good on master either, feel free to propose something better) image image
nav buttons in module are very saturated (might be a matter of preference) image image

@jfmcquade
Copy link
Copy Markdown
Collaborator Author

@FaithDaka See this PR description – it includes the changes that were originally in #3140, which were addressing #3200.

Please could you either update this PR or create a new one to address #3200 directly. Some points to note:

  • [CHORE] Refactor plh_kids_kw theme to use new theme colour vars #3099 has now been merged, which may have knock-ons for this PR (I believe the ZA theme is base don the KW theme directly)
  • See @esmeetewinkel's comment above for a list of colour changes that probably aren't acceptable. We'll likely want to tweak this theme to override its *-variant colours, or else make a case for the changes from a design point of view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants