Added 3 files: test-export_cdt.R, test-export_cdt_daily.R and test-ex…#78
Open
HawardKetoyoMsatsi wants to merge 9 commits intoIDEMSInternational:mainfrom
Open
Added 3 files: test-export_cdt.R, test-export_cdt_daily.R and test-ex…#78HawardKetoyoMsatsi wants to merge 9 commits intoIDEMSInternational:mainfrom
HawardKetoyoMsatsi wants to merge 9 commits intoIDEMSInternational:mainfrom
Conversation
…port_cdt_dekad.R
Three files are created here: test-export_cdt.R, test-export_cdt_daily.R and test-export_cdt_dekad.R
Files export_cdt.R, export_cdt_daily.R and export_cdt_dekad.R doesnt recognise "element" in the input (file_path = paste0("CDT-", element, ".csv")
(this should be fixed for the tests to run)
The files test that the
1. functions give the correct output.
2. functions give an error whenever mandatory inputs are missing.
Updated read_csv function of readr package.
lloyddewit
requested changes
Apr 8, 2022
Merged
Update_cdt
…ort_cdtdekad.R Updated Functions test-esport_cdt.R, test-esport_cdt.dailyR, test-esport_cdtdekad.R Tests added include:- 1. the function returns an error when numbers outside valid ranges are supplied 2. the function does not return an error when an empty dataframe is supplied 3. the function returns an error when an data frame with incorrectly formatted data is supplied
Collaborator
|
@HawardKetoyoMsatsi the problem in the missing |
Added readr package in the DESCRIPTION file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is ready for review.
Three files are created here: test-export_cdt.R, test-export_cdt_daily.R and test-export_cdt_dekad.R
Files export_cdt.R, export_cdt_daily.R and export_cdt_dekad.R doesnt recognise "element" in the input (file_path = paste0("CDT-", element, ".csv") (this should be fixed for the tests to run)
The files test that the