Remove dead hold scanner#32
Merged
Merged
Conversation
main only runs stabilizer.RunTTLScanner. The hold package still had its own expiry scanner and finalizers. That gave us two callback shapes, two ledger sources, and two state paths. Delete the dead scanner. Keep the TTL coverage on the stabilizer path that actually runs. Closes #23
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Deleted the old hold expiry scanner.
main only starts
stabilizer.RunTTLScanner. The old scanner had separate finalizers, callback payloads, idempotency keys, and ledger source.Added TTL tests for the stabilizer path.
Tested:
GOCACHE=/tmp/paystable-issue23-gocache go test ./...