Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yguel humble fix warnings and memory leak #128

Merged

Conversation

yguel
Copy link
Contributor

@yguel yguel commented Jun 7, 2024

No description provided.

Fix warnings

Remove warnings.

Fix formatting

Finish fixing warnings.
@yguel yguel requested a review from tpoignonec June 7, 2024 12:11
@yguel yguel force-pushed the yguel-humble-fix-warnings-and-memory-leak branch from 4bae5ec to 6da4328 Compare June 11, 2024 15:29
@yguel yguel merged commit 5882251 into ICube-Robotics:humble Jun 13, 2024
1 check passed
Copy link
Member

@tpoignonec tpoignonec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yguel Le compilateur te dérange pas avec les casts implicites?

@yguel
Copy link
Contributor Author

yguel commented Jun 25, 2024

Which one ? If I have missed one, the compiler did not complain about it. I mainly changed implicit casts to explicit to avoid the warnings.

Ormared added a commit to Ormared/ethercat_driver_ros2 that referenced this pull request Feb 6, 2025
Yguel humble fix warnings and memory leak (ICube-Robotics#128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants