Flatten jenkins vars for overloading #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is proposed in order to have a more fine grain control over Jenkins install versions. With release of Jenkins 2.0 the current role fails to install. This change allows for easy overriding of jenkins variables in order to point to different mirrors. Changes: - Flatten the nested vars file - Add jenkins namespacing prefixes. - Abstracted out the debian apt_key and redhat repo and key urls in order to allow for variable overloading.
eric-weaver
force-pushed
the
flatten-jenkins-vars
branch
from
56d543d
to
89fffe1
Compare
|
This namespacing change will allow for the role variables to be moved into defaults allowing for overriding of variables outside this role which can be see at the following commit: cnry@fc05b7e The benefit of this would be to allow installing of dependencies from mirrors rather than relying on the upstream repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is proposed in order to have a more fine grain control over
Jenkins install versions. With release of Jenkins 2.0 the current role
fails to install. This change allows for easy overriding of jenkins
variables in order to point to different mirrors.
Changes:
order to allow for variable overloading.