fix: spacy model download with pyinstaller
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemDoum
force-pushed
the
fix/spacy-with-pyinstaller
branch
from
9822699 to
8f029be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
As specified here,
pyinstallerdoesn't support starting a subprocess which call the python interpreter, since there's no interpreter in the binary built bypysintaller.spacy.downloadhowever does callpython -m pip install ....to install models.This PR implements a hack to bypass this limitation, it additionally provides a hook to correctly install spacy in the pyinstaller build.
Changes
Changed
spacy.downloadAdded