Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MultipleSourceLoader lazy and fix its use of fusion #1602

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Make MultipleSourceLoader lazy and fix its use of fusion #1602

merged 4 commits into from
Feb 12, 2025
+20 −12

Conversation

elronbandel
Copy link
Member

No description provided.

yoavkatz
yoavkatz reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@yoavkatz yoavkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't the Unitxt unit tests not fail ? Can we make a unit test that validates the fix?

@elronbandel
Copy link
Member Author

Added test that validated the fix @yoavkatz

@elronbandel
Fix test
8e145b1 
Signed-off-by: elronbandel <[email protected]>
@elronbandel elronbandel merged commit d7200b5 into main Feb 12, 2025
16 checks passed
@elronbandel elronbandel deleted the fix-multiple-source-loader branch February 12, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavkatz yoavkatz yoavkatz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elronbandel @yoavkatz