Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include inference time in performance report only when not-mocked #1572

Closed
wants to merge 5 commits into from

Conversation

dafnapension
Copy link
Collaborator

because inference is mocked, and evaluation is not indicative if runs over mocked predictions

@dafnapension dafnapension changed the title remove inference time and evaluation time from performance report include inference time in performance report only when not-mocked Feb 4, 2025
@dafnapension dafnapension force-pushed the polish_performance branch 3 times, most recently from 94bc4ec to 7ca3758 Compare February 10, 2025 08:59
dafnapension and others added 5 commits February 13, 2025 10:54
…cause inference is mocked, and evaluation is not indicative if runs over mocked predictions

Signed-off-by: dafnapension <[email protected]>
* minor bug fixes

* adding anls

* Added LMMS_eval template, exact_match_mm metric, RGB image augmentor.

* Added qa.with_context_multiple choice lmms_eval template

* Added relaxed_correctness metric, edited info_vqa card, edit lmms_eval template

* minor script changes

* minor run changes

* Added default template

* Added lmms-lab version of chartqa with default template and relaxed correctness metric and with_type task

* Added lmms-lab card of info_vqa. added default template to info_vqa and docvqa

* Wevsrc new with_domain task, new metric. WIP

* websrc working

* discarding not important changes from main

* workaround for llama_vision with WML

* WML vs local UNITXT reproductions

* Added llama vision benchmark

* Changes for commit

* fix unitxt typo

* ruff

* Update inference engine model and adjust expected targets in tests

Signed-off-by: elronbandel <[email protected]>

* Fix WML Inference Engine tests for images

Signed-off-by: elronbandel <[email protected]>

* Update tests

Signed-off-by: elronbandel <[email protected]>

* Enhance CSV loader with low_memory option and update inference engine tests for set equality

Signed-off-by: elronbandel <[email protected]>

* Add error handling in Loader class to raise UnitxtError on load_iterables failure

Signed-off-by: elronbandel <[email protected]>

---------

Signed-off-by: elronbandel <[email protected]>
Signed-off-by: dafnapension <[email protected]>
@dafnapension
Copy link
Collaborator Author

covered by #1600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants