Bug fix on destroy flow and logging improvements #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharaneeshvrd
force-pushed
the
bug-fix-and-log-improvement
branch
from
58d93bd to
6793664
Compare
manju956
reviewed
Oct 21, 2025
| if len(active_vios_servers) == 0: | ||
| logger.error("failed to find active VIOS server") | ||
| raise VIOSError("failed to find active VIOS server") | ||
| raise VIOSError(f"no active VIOS server attached to the system '{util.get_host_address(config)}'") |
There was a problem hiding this comment.
host address will be pointing to HMC IP. probably we can mention the system id or get corresponding system name and log.
manju956
reviewed
Oct 21, 2025
| f"failed to attach '{physical_volume_name}' physical storage in VIOS '{vios_storage_uuid}'") | ||
| if index == len(vios_storage_list) - 1: | ||
| raise e | ||
| raise StorageError(f"failed to attach '{physical_volume_name}' physical storage in VIOS '{vios_storage_uuid}', error: {e}") |
There was a problem hiding this comment.
guess we can rephrase to failed to attach physical storage: {'{physical_volume_name}' to VIOS '{vios_storage_uuid}'
manju956
reviewed
Oct 21, 2025
|
looks good to me as well |
Add request handling exceptions Signed-off-by: Dharaneeshwaran Ravichandran <[email protected]>
dharaneeshvrd
force-pushed
the
bug-fix-and-log-improvement
branch
from
77de230 to
ebfec1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.