Skip to content

[UI] Vite Migration#38

Merged
mayuka-c merged 3 commits intoIBM:mainfrom
mayuka-c:vite-migration
Mar 11, 2026
Merged

[UI] Vite Migration#38
mayuka-c merged 3 commits intoIBM:mainfrom
mayuka-c:vite-migration

Conversation

@mayuka-c
Copy link
Member

@mayuka-c mayuka-c commented Feb 18, 2026 •
edited
Loading

@mayuka-c mayuka-c force-pushed the vite-migration branch 3 times, most recently from 09e4845 to 6aad9d4 Compare February 18, 2026 11:29
@mayuka-c mayuka-c changed the title Vite Migration [UI] Vite Migration Feb 18, 2026
Niharika0306
Niharika0306 reviewed Mar 9, 2026
View reviewed changes
Niharika0306
Niharika0306 reviewed Mar 9, 2026
View reviewed changes
Niharika0306
Niharika0306 reviewed Mar 9, 2026
View reviewed changes
@Niharika0306
Copy link
Contributor

Niharika0306 commented Mar 9, 2026

Rest, everything LGTM.

mayuka-c and others added 3 commits March 10, 2026 18:24
@mayuka-c
Vite Migration
1cbca9d 
Signed-off-by: mayuka-c <Mayuka.C@ibm.com>

Vite config update

Signed-off-by: mayuka-c <Mayuka.C@ibm.com>

Update yarn.lock

Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
@mayuka-c
Vite dev dependency
f28c055 
Signed-off-by: mayuka-c <mayuka.c@ibm.com>
@mayuka-c
Address comments
5eba8bc 
Signed-off-by: mayuka-c <mayuka.c@ibm.com>
@mayuka-c
Copy link
Member Author

mayuka-c commented Mar 10, 2026 •
edited
Loading

@Niharika0306 I have made the changes and validated once more in staging. Its working fine.
PTAL and if fine we can merge.

@Niharika0306
Copy link
Contributor

Niharika0306 commented Mar 11, 2026

LGTM.
Few small nits - The Readme still reflects the CRA way of running things. So if we could update that in another PR , it would be great. And also mention the env variables such as VITE_PAC_GO_SERVER_TARGET in the Readme would be helpful.

@mayuka-c
Copy link
Member Author

mayuka-c commented Mar 11, 2026 •
edited
Loading

LGTM. Few small nits - The Readme still reflects the CRA way of running things. So if we could update that in another PR , it would be great. And also mention the env variables such as VITE_PAC_GO_SERVER_TARGET in the Readme would be helpful.

I will create an issue for this and also for removing external assets in index.html if not required which we are adding.

Prob let me see I will take care of README in the current PR itself once I get some time

@mayuka-c mayuka-c merged commit 1bf98c8 into IBM:main Mar 11, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikasbolla vikasbolla Awaiting requested review from vikasbolla

@srivastav-abhishek srivastav-abhishek Awaiting requested review from srivastav-abhishek

1 more reviewer

@Niharika0306 Niharika0306 Niharika0306 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Web] Migrate UI from using Webpack to Vite

2 participants

@mayuka-c @Niharika0306