Fix bug when removing finalizer #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Honaker <[email protected]>
Signed-off-by: Michael Honaker <[email protected]>
HonakerM
force-pushed
the
fix_status_finalizer
branch
from
99ef2e5 to
0ae6282
Compare
Signed-off-by: Michael Honaker <[email protected]>
HonakerM
force-pushed
the
fix_status_finalizer
branch
from
4d5b0ec to
9cf38f8
Compare
gabe-l-hart
approved these changes
Dec 5, 2023
| if not self._cluster_content[namespace][kind][api_version][name][ | ||
| "metadata" | ||
| ].get("finalizers"): | ||
| callback(self._cluster_content[namespace][kind][api_version][name]) |
There was a problem hiding this comment.
Does this need to be behind the DRY_RUN_CLUSTER_LOCK (or alternately, have the value pulled above and then used here)?
| @@ -243,7 +247,14 @@ def remove_finalizer(session: SESSION_TYPE, finalizer: str): | |||
|
|
|||
| log.debug("Removing finalizer: %s", finalizer) | |||
|
|
|||
| manifest = copy.deepcopy(session.cr_manifest) | |||
| # Create manifest with only required fields | |||
There was a problem hiding this comment.
Ah, perfect. This will be much simpler
| @@ -105,8 +105,10 @@ def run_reconcile(self, is_finalizer: bool, resource: dict): | |||
| if ( | |||
| self._resource.get("kind") == resource.get("kind") | |||
| and self._resource.get("apiVersion") == resource.get("apiVersion") | |||
| and resource_metadata.get("name") == resource_metadata.get("name") | |||
There was a problem hiding this comment.
Yikes! Those were certainly buggy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Supports #?
Related PRs
This PR is not dependent on any other PR
What this PR does / why we need it
This PR updates the
remove_finalizerutility to only apply the necessary parameters instead of applying the whole resource.Special notes for your reviewer
If applicable**
What gif most accurately describes how I feel towards this PR?