-
Notifications
You must be signed in to change notification settings - Fork 5
Regional e2e #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Regional e2e #76
Conversation
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
Signed-off-by: Renuka <[email protected]>
|
👍 Coverage remained same at [87.9567%] |
|
@renukasingare as discussed please follow below code for acadia block we cannot fail the case , I was under assumption we are passing the case. I am ok if you combine the cases or you can have different negative case. |
Signed-off-by: Renuka <[email protected]>
|
👍 Coverage remained same at [87.9567%] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cloud.ibm.com/docs/vpc?topic=vpc-file-storage-profiles&interface=ui#rfs-profile
Refer this and put only range supported for regional
Signed-off-by: Renuka <[email protected]>
|
👍 Coverage remained same at [87.9567%] |
Signed-off-by: Renuka <[email protected]>
|
👍 Coverage remained same at [87.9567%] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check comments
Signed-off-by: Renuka <[email protected]>
|
👍 Coverage remained same at [87.9567%] |
Signed-off-by: Renuka <[email protected]>
|
👍 Coverage remained same at [87.9567%] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renukasingare this looks good but check once why jenkins is failing , check the return error code from your execution of cases.
|
@sameshai now e2e is getting passed for regional e2e can you please approve this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good please , open GHE to add other Advance cases along with KP encryption use case. Lets plan to add that as we get more time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check and do the changes accordingly, better to create PR in your name @renukasingare
No description provided.