Skip to content

Conversation

@sameshai
Copy link
Member

@sameshai sameshai commented Sep 8, 2025

No description provided.

@sameshai sameshai self-assigned this Sep 8, 2025
@sameshai
Copy link
Member Author

sameshai commented Sep 8, 2025

👍 Coverage remained same at [87.9567%]

@sameshai
Copy link
Member Author

@renukasingare as discussed please follow below code for acadia block we cannot fail the case , I was under assumption we are passing the case. I am ok if you combine the cases or you can have different negative case.

https://github.com/IBM/ibm-csi-common/blob/14a86ebb4c2f14e58a1d5dcaf40d95a02badf54e/tests/e2e/pvc_tests.go#L875

@sameshai
Copy link
Member Author

👍 Coverage remained same at [87.9567%]

Copy link
Member Author

@sameshai sameshai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameshai
Copy link
Member Author

👍 Coverage remained same at [87.9567%]

@sameshai
Copy link
Member Author

👍 Coverage remained same at [87.9567%]

Copy link
Member Author

@sameshai sameshai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

Signed-off-by: Renuka <[email protected]>
@sameshai
Copy link
Member Author

👍 Coverage remained same at [87.9567%]

@sameshai
Copy link
Member Author

👍 Coverage remained same at [87.9567%]

Copy link
Member Author

@sameshai sameshai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renukasingare this looks good but check once why jenkins is failing , check the return error code from your execution of cases.

@renukasingare
Copy link
Contributor

@sameshai now e2e is getting passed for regional e2e
E2E :-> https://alchemy-containers-jenkins.swg-devops.com/job/Containers-Volumes/job/ibm-vpc-csi-file-e2e/4963/

can you please approve this PR

Copy link
Member Author

@sameshai sameshai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good please , open GHE to add other Advance cases along with KP encryption use case. Lets plan to add that as we get more time.

Copy link
Collaborator

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check and do the changes accordingly, better to create PR in your name @renukasingare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants