-
Couldn't load subscription status.
- Fork 5
ENI support #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENI support #15
Changes from all commits
adfefb0
2dc2601
e887726
a3053eb
9bd9cf4
6860fff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,14 +19,11 @@ package models | |
|
|
||
| const ( | ||
| // APIVersion is the target RIaaS API spec version | ||
| APIVersion = "2023-05-30" | ||
| APIVersion = "2023-07-11" | ||
|
|
||
| // APIGeneration ... | ||
| APIGeneration = 1 | ||
|
|
||
| // UserAgent identifies IKS to the RIaaS API | ||
| UserAgent = "IBM-Kubernetes-Service" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what would be the impact when we remove MaturityBeta = "beta" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The impact would be that by default the ENI mode will be applied i.e When user uses dp2 profile PVC will be created with ENI mode. Earlier it was VPC mode(Non-ENI). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what would be the impact for existing PVCs? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The existing PVCS there is no impact. If user deletes the PVCS the shares and mount_targets API will be able to delete file share and file share target. |
||
|
|
||
| // MaturityBeta flag | ||
| MaturityBeta = "beta" | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /******************************************************************************* | ||
| * IBM Confidential | ||
| * OCO Source Materials | ||
| * IBM Cloud Kubernetes Service, 5737-D43 | ||
| * (C) Copyright IBM Corp. 2023 All Rights Reserved. | ||
| * The source code for this program is not published or otherwise divested of | ||
| * its trade secrets, irrespective of what has been deposited with | ||
| * the U.S. Copyright Office. | ||
| ******************************************************************************/ | ||
|
|
||
| // Package models ... | ||
| package models | ||
|
|
||
| import ( | ||
| "github.com/IBM/ibmcloud-volume-interface/lib/provider" | ||
| ) | ||
|
|
||
| // SecurityGroup ... | ||
| type SecurityGroup struct { | ||
| CRN string `json:"crn,omitempty"` | ||
| Href string `json:"href,omitempty"` | ||
| ID string `json:"id,omitempty"` | ||
sameshai marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Name string `json:"name,omitempty"` | ||
| ResourceGroup *ResourceGroup `json:"resource_group,omitempty"` | ||
| VPC *provider.VPC `json:"vpc,omitempty"` | ||
| } | ||
|
|
||
| // SecurityGroupList ... | ||
| type SecurityGroupList struct { | ||
| First *HReference `json:"first,omitempty"` | ||
| Next *HReference `json:"next,omitempty"` | ||
| SecurityGroups []SecurityGroup `json:"security_groups,omitempty"` | ||
| Limit int `json:"limit,omitempty"` | ||
| TotalCount int `json:"total_count,omitempty"` | ||
| } | ||
|
|
||
| // ListSecurityGroupFilters ... | ||
| type ListSecurityGroupFilters struct { | ||
| ResourceGroupID string `json:"resource_group.id,omitempty"` | ||
| VPCID string `json:"vpc.id,omitempty"` | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /******************************************************************************* | ||
| * IBM Confidential | ||
| * OCO Source Materials | ||
| * IBM Cloud Kubernetes Service, 5737-D43 | ||
| * (C) Copyright IBM Corp. 2023 All Rights Reserved. | ||
| * The source code for this program is not published or otherwise divested of | ||
| * its trade secrets, irrespective of what has been deposited with | ||
| * the U.S. Copyright Office. | ||
| ******************************************************************************/ | ||
|
|
||
| // Package models ... | ||
| package models | ||
|
|
||
| import ( | ||
| "github.com/IBM/ibmcloud-volume-interface/lib/provider" | ||
| ) | ||
|
|
||
| // Subnet ... | ||
| type Subnet struct { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can these 3 variable replaced with SubnetRef There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can try it out but we can take this up as improvement. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure |
||
| CRN string `json:"crn,omitempty"` | ||
| Href string `json:"href,omitempty"` | ||
| ID string `json:"id,omitempty"` | ||
sameshai marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Name string `json:"name,omitempty"` | ||
| ResourceGroup *ResourceGroup `json:"resource_group,omitempty"` | ||
| VPC *provider.VPC `json:"vpc,omitempty"` | ||
| Zone *Zone `json:"zone,omitempty"` | ||
| } | ||
|
|
||
| // SubnetRef ... | ||
| type SubnetRef struct { | ||
| CRN string `json:"crn,omitempty"` | ||
| ID string `json:"id,omitempty"` | ||
| Href string `json:"href,omitempty"` | ||
| } | ||
|
|
||
| // SubnetList ... | ||
| type SubnetList struct { | ||
| First *HReference `json:"first,omitempty"` | ||
| Next *HReference `json:"next,omitempty"` | ||
| Subnets []Subnet `json:"subnets,omitempty"` | ||
| Limit int `json:"limit,omitempty"` | ||
| TotalCount int `json:"total_count,omitempty"` | ||
| } | ||
|
|
||
| // ListSubnetFilters ... | ||
| type ListSubnetFilters struct { | ||
| ResourceGroupID string `json:"resource_group.id,omitempty"` | ||
| VPCID string `json:"vpc.id,omitempty"` | ||
| ZoneName string `json:"zone.name,omitempty"` | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.