Updated Instance type prompt with GPU info for GCP Cloud #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haresh-Kumar-K-J <[email protected]>
Signed-off-by: HareshKumarkj <[email protected]>
|
@sasikeda please review the PR. |
sasikeda
reviewed
Jun 30, 2025
| @@ -161,6 +163,7 @@ module "storage_cluster_tie_breaker_instance" { | |||
| boot_disk_size = var.storage_cluster_boot_disk_size | |||
| boot_disk_type = var.storage_cluster_boot_disk_type | |||
| boot_image = var.storage_cluster_image_ref | |||
| is_gpu_instance = var.is_gpu_enabled | |||
There was a problem hiding this comment.
In storage profile, gpu instances are not required. GPU instances are limited only to compute. But it is okay to keep, no harm
| @@ -91,6 +91,7 @@ module "compute_cluster_instances" { | |||
| boot_disk_size = var.compute_cluster_boot_disk_size | |||
| boot_disk_type = var.compute_cluster_boot_disk_type | |||
| boot_image = var.compute_cluster_image_ref | |||
| is_gpu_instance = var.is_gpu_enabled | |||
There was a problem hiding this comment.
kindly check if this datasource has problems. we can reach to support to see if it does not work.
https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/compute_machine_types#nested_accelerators
| @@ -93,6 +95,13 @@ resource "google_compute_instance" "itself" { | |||
| lifecycle { | |||
| ignore_changes = all | |||
| } | |||
|
|
|||
| dynamic "scheduling" { | |||
There was a problem hiding this comment.
can we use below to simplify
condition ? true_val : false_val
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.