Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hap score - Example Notebook #840
Hap score - Example Notebook #840
Changes from all commits
8cb170d
3d123a4
06599a5
0bdc9a1
dcdc2f7
27c6e9a
f2f9c9d
eca9faa
b2193f5
c66bc10
8d29d3a
e046a31
31b7d4d
6b58de4
512a4e3
06a2936
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove data-prep-connector since you are NOT using it. This line can be deleted:
! pip install data-prep-connectorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need this line. Those are transitive dependencies of the transform itself and could break the notebook in the future if they are changed by new releases of the ransform.
! pip install nltk==3.9.1 transformers==4.38.2 torch>=2.2.2,<=2.4.1 pandas==2.2.2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these is my fault, @touma-I! Since I could get the notebook to work only after pip installing requirements.txt, I thought they were needed, but it turns out my problem was something else! In any case, what you are saying is that these dependencies are taken care of by the pip install of the transform itself and should not be done here.