[KFP v2] Fix the S3 secret name is hardcoded in the KFP library. #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roytman
reviewed
Feb 10, 2025
| # FIXME: Due to kubeflow/pipelines#10914, secret names cannot be provided as pipeline arguments. | ||
| # As a workaround, the secret name is hard coded. | ||
| env2key = ComponentUtils.set_secret_key_to_env() | ||
| kubernetes.use_secret_as_env(task=execute_job, secret_name="s3-secret", secret_key_to_env=env2key) |
There was a problem hiding this comment.
I suggest defining a constant at the start of the file and using it here. It will simplify for users to update it.
revit13
force-pushed
the
secret_kfp_v2
branch
2 times, most recently
from
841db06 to
ece26e2
Compare
roytman
approved these changes
Feb 10, 2025
|
@revit13 Can you merge with the latest from dev and let me know if this fixes the problem with the kfp1 test for lang_id ? I had to add a read-only secret for hugging face, exposed that in the workflow as an env. variable and then use it in the lang_id_wf.py (more details here: #1068). I am looking at code_quality now. |
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
FIX - Due to kubeflow/pipelines#10914, we cannot provide secret names as pipeline arguments, so we agreed to a workaround that the secret name will be hard-coded.
The secret names should be in pipeline, so users will be able to overwrite them. Currently it is in the library, so users cannot change it.
Related issue number (if any).
#985