Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply tolerations to ray pods defined by env var in KFP v2 #648

Closed
1 of 2 tasks
revit13 opened this issue Oct 1, 2024 · 1 comment
Closed
1 of 2 tasks

Apply tolerations to ray pods defined by env var in KFP v2 #648

revit13 opened this issue Oct 1, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@revit13
Copy link
Collaborator

revit13 commented Oct 1, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

KFP workflows

Feature

Related to #620 and PRs #643 and #627

Following @roytman request in this pr tolerations for ray pods (and kfp pods) can be applied for KFP v1 when exporting the following env var before compiling the pipeline; however, for KFPv2 its is not supported yet.

export KFP_TOLERATIONS='[{"key": "key","operator": "Equal", "value1": "value", "effect": "NoSchedule"}]'

In addition, for both KFP v1 and v2 the tolerations for ray pods can be specified in the pipeline params: ray_head_options and ray_worker_options.
for example:

  "cpu": 1,
  "image": "quay.io/dataprep1/data-prep-kit/noop-ray:latest",
  "memory": 4,
  "tolerations": [
    {
      "key": "preprocessing",
      "operator": "Equal",
      "value": "dedicated",
      "effect": "NoSchedule"
    }
  ]
}

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@revit13 revit13 added the enhancement New feature or request label Oct 1, 2024
@roytman
Copy link
Member

roytman commented Oct 4, 2024

Done with #627 and #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants