Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add nodes affinity / Toleration to KFP/Ray nodes #620

Closed
2 tasks done
roytman opened this issue Sep 24, 2024 · 4 comments
Closed
2 tasks done

[Feature] Add nodes affinity / Toleration to KFP/Ray nodes #620

roytman opened this issue Sep 24, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@roytman
Copy link
Member

roytman commented Sep 24, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

KFP workflows, Library/kfp

Feature

Some Kubernetes deployments require that KFP and Ray Pods deploy on a certain set of nodes.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@roytman roytman added the enhancement New feature or request label Sep 24, 2024
@blublinsky
Copy link
Collaborator

blublinsky commented Sep 24, 2024

This is supported by the API server through compute template definition https://github.com/ray-project/kuberay/blob/master/proto/config.proto#L130. Pod toleration is here https://github.com/ray-project/kuberay/blob/master/proto/config.proto#L104C9-L104C17. Documentation on toleration usage is here https://medium.com/@muppedaanvesh/kubernetes-taints-tolerations-b0e0ed076cad

@roytman
Copy link
Member Author

roytman commented Sep 24, 2024

I know, but in order to use it we have to update our KFP library.
On the other hand, KFP supports affinity for its Pods, but again we have to update the pipelines.

@blublinsky
Copy link
Collaborator

I was making sure API server supports it

@roytman
Copy link
Member Author

roytman commented Oct 4, 2024

Done with #627, #643 and #648

@roytman roytman closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants