refact: Clarify belong_to_segment algorithm
#118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier G. Sogo <[email protected]>
Signed-off-by: Javier G. Sogo <[email protected]>
rainerschoe
reviewed
Sep 22, 2025
| /// * the entity contains the requested attribute, AND | ||
| /// * the entity attribute satisfies ANY of the rule values. | ||
| /// | ||
| /// TODO: What if rules.values is empty? Now it returns false |
There was a problem hiding this comment.
I guess this is fine as a corner-case. A rule with no values does not make much sense. Maybe in the future we get some cross-client tests to ensure that all clients behave the same here xD
jgsogo
commented
Sep 22, 2025
Comment on lines
52
to
53
| entity | ||
| .get_attributes() |
There was a problem hiding this comment.
btw, I forgot to mention this here:
This get_attributes is returning a HashMap (note no reference), so here it will creating a new map for every Rule. I don't like this. Maybe we should return here a reference and it's up to the user to pass an Entity that doesn't generate the map again and again. Wdyt?
…gment Signed-off-by: Javier G. Sogo <[email protected]>
…efact/belong_to_segment
Signed-off-by: Travis <[email protected]>
Signed-off-by: Travis <[email protected]>
Signed-off-by: Travis <[email protected]>
rainerschoe
force-pushed
the
refact/belong_to_segment
branch
from
82e072f to
122c0c2
Compare
rainerschoe
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatchesEntitytrait that is implemented forSegmentandRuleso we can isolate the logic that applies to each one of them when matching an entity.