Skip to content

chore: readme and pyproject tomlupdate for pypi packaging#9

Merged
dennislwei merged 2 commits intoIBM:mainfrom
ingelise:main
Oct 11, 2025
Merged

chore: readme and pyproject tomlupdate for pypi packaging#9
dennislwei merged 2 commits intoIBM:mainfrom
ingelise:main

Conversation

@ingelise
Copy link
Member

@ingelise ingelise commented Oct 8, 2025

Updates the readmes and pyproject.toml file for pypi packaging.

  • Update contributing guideline to with IBM's detect-secrets secret scanning instructions
  • Update main readme installation instructions
  • Update to pyproject.toml to remove direct dependencies for the packaging

Signed-off-by: Inge Vejsbjerg<ingevejs@ie.ibm.com>
@ingelise ingelise requested a review from dennislwei October 8, 2025 14:39
Copy link
Member

@dennislwei dennislwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ingelise. I left some minor comments on the README that will be very quick to fix.

README.md Outdated
```
Download the spacy models for use in the project
```
uv run python -m spacy download en_core_web_trf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'en_core_web_trf' is repeated. One of them should be 'en_core_web_sm'.

README.md Outdated
uv venv --python 3.12
source .venv/bin/activate
uv pip install .
uv run python -m spacy download en_core_web_trf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same repeat

README.md Outdated
uv venv --python 3.12
.venv/bin/activate
uv pip install .
uv run python -m spacy download en_core_web_trf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same repeat

README.md Outdated

3. **Token Highlighter: Inspecting and Mitigating Jailbreak Prompts for Large Language Models**: Explains potential jailbreak threats by highlighting important prompt tokens based on model gradients. [![Read Paper](https://img.shields.io/badge/Read%20Paper-PDF-yellow)](https://arxiv.org/pdf/2412.18171) [![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/IBM/ICX360/blob/main/examples/th/quick_start.ipynb)

## Download package from pypi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please change this to "Install package from PyPI" since it includes both downloading and installing?

README.md Outdated
```


## Download from repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly "Install from repo"

README.md Outdated
## Download from repo


## Prerequisites
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this heading should be ### Prerequisites because it's a heading under ## Install from repo. Similarly ## Installation -> ### Installation below.

Signed-off-by: Inge Vejsbjerg<ingevejs@ie.ibm.com>
@ingelise
Copy link
Member Author

ingelise commented Oct 9, 2025

Thanks @dennislwei, I have updated these errors.

@ingelise ingelise requested a review from dennislwei October 9, 2025 20:05
Copy link
Member

@dennislwei dennislwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dennislwei dennislwei merged commit 793a13a into IBM:main Oct 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants