6x feature, 2x BugFix #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugFix: - runtime_template root: add check_mode and force parameter to be passed through delete call - runtime_template file: File checker should compare to None, otherwise if id=0 the check would generate a false positive Feature: Directory create with id function added
perform compare checks for zip on: - number of files - file content comparison one by one
adding verification check on runtime template root files between server and zip in import_file function. (makes use of new function: files_same_zip_content in ibmsecurity.utilities.tools)
adding verification check on management root files between server and zip in import_file function. (makes use of new function: files_same_zip_content in ibmsecurity.utilities.tools)
Collaborator
|
I have changed for runtime_template that I need to merge as well. So will need to work this one carefully. |
Upload of aac runtime template files needs path+name instead of id for check and delete function
If zip files for runtime template comparison is missing, skip it. This indicates aac or federation module is maybe not activated
Configure entire scim with idempotency checking
… restrictions) load of signer certificates had following issues: - loading of local runtime certificates not possible (e.g. ansible can not reach local aac runtime certificate for checking) - ansible is required to be able to load the certificate for comparison (firewall restrictions can prevent this to work properly) fix: additional parameter "check_remote" introduces. description: parameter "check_remote" controls whether to load remote certificate into ansible for comparison or to simply compare the kdb for existance of the label. For backward compatibility and default behavior (LMI) reasons "check_remote" parameter is set to False by default.
…rties by name This feature attempts to find the uuids from the properties "EmailMessage.serverConnection", "ScimConfig.serverConnection" and "CI.serverConnection". If a UUID is found, the value for this property is replaced by this UUID, otherwise the value remains unchanged. This allows you to set ServerConnections by name, while still allowing you to create the ServerConnection directly from the UUID.
…ld numbering ValueError: cannot switch from manual field specification to automatic field numbering
…connection parameters Adding compare functionality to all server connection types: ci, ldap, smtp, ws, jdbc 1. Attention: ci server connection parameter changed. Following functions set update delete have been updated to work with the name parameter instead of id parameter. 2. Attention: jdbc type parameter removed and made static = 'db2' All these changes are adjustments to harmonize the functions signature accross all server connections (ci, ldap, ws, smtp, jdbc)
REST API does two checks: 1. name already exist 2. filename (under which the file will be stored to the appliance) already exist The checks are indepentent from each other. If one of the checks fails an error will be raised by API call. _check function now reflects this behaviour by checking name and filename parameter for conflicts.
manual re-engineering of server_connections ci, jdbc, smtp and ws from previous commit (1d1bb76) to resolve merge conflict easily.
Contributor
Author
|
Before accepting the pull request, following considerations:
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
BugFix [aac\runtime_template]: