Skip to content

chore: refresh code health baseline after refactor - #96

Merged
IAnMove merged 1 commit into
mainfrom
chore/update-code-health-baseline
Sep 2, 2026
Merged

chore: refresh code health baseline after refactor#96
IAnMove merged 1 commit into
mainfrom
chore/update-code-health-baseline

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

Refresh scripts/code_health_baseline.json after the Story Lab refactor landed in #91 and the code-health ratchet in #92.

The previous baseline still counted the old StoryLabPanel.tsx size and complexity, so python scripts/code_health.py --check reported five false-positive new hotspots from the extracted Story components. This PR records the current post-refactor measurements; it does not change thresholds or production code.

Validation

  • Before refresh: python scripts/code_health.py --check reproduced exactly five hotspot regressions:
    • StoryProductionsMusicPanel.tsx (101)
    • StoryProductionsTab.tsx (59)
    • StoryTrailerTab.tsx (47)
    • CompactVideoWorkspace.tsx (46)
    • StoryMusicTab.tsx (38)
  • python scripts/code_health.py --write-baseline
  • python -m unittest tests/test_code_health.py (4 passed)
  • python scripts/code_health.py --check (pass, no regressions)
  • python -m json.tool scripts/code_health_baseline.json (pass)
  • git diff --check (pass)

Only scripts/code_health_baseline.json is changed.


Note

Low Risk
Metadata-only baseline refresh for CI metrics; no runtime, security, or behavioral changes.

Overview
Updates scripts/code_health_baseline.json so python scripts/code_health.py --check matches the repo after the Story Lab split—no thresholds or app code change.

Summary counts tick up slightly (e.g. production files 458→467, complex_functions 767→771). StoryLabPanel.tsx drops in size (7012→5389 LOC hotspot) and cyclomatic complexity (435→163); top_complexity moves its line reference (684→466). The baseline now includes extracted Story UI modules (StoryProductionsMusicPanel, StoryProductionsTab, StoryTrailerTab, CompactVideoWorkspace, StoryMusicTab) so the ratchet stops flagging them as new hotspots. sceneRecipe.ts complexity entry line shifts 1493→1515.

Reviewed by Cursor Bugbot for commit 07d8a01. Configure here.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 1 file(s); +22/-17; repo scripts / CI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • No heuristic issues. Still run the CI checklist below.

Changed files

  • modified: scripts/code_health_baseline.json

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove
IAnMove merged commit bb8535b into main Sep 2, 2026
5 checks passed
@IAnMove
IAnMove deleted the chore/update-code-health-baseline branch September 5, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant