chore: refresh code health baseline after refactor - #96
Merged
Conversation
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh
scripts/code_health_baseline.jsonafter the Story Lab refactor landed in #91 and the code-health ratchet in #92.The previous baseline still counted the old
StoryLabPanel.tsxsize and complexity, sopython scripts/code_health.py --checkreported five false-positive new hotspots from the extracted Story components. This PR records the current post-refactor measurements; it does not change thresholds or production code.Validation
python scripts/code_health.py --checkreproduced exactly five hotspot regressions:StoryProductionsMusicPanel.tsx(101)StoryProductionsTab.tsx(59)StoryTrailerTab.tsx(47)CompactVideoWorkspace.tsx(46)StoryMusicTab.tsx(38)python scripts/code_health.py --write-baselinepython -m unittest tests/test_code_health.py(4 passed)python scripts/code_health.py --check(pass, no regressions)python -m json.tool scripts/code_health_baseline.json(pass)git diff --check(pass)Only
scripts/code_health_baseline.jsonis changed.Note
Low Risk
Metadata-only baseline refresh for CI metrics; no runtime, security, or behavioral changes.
Overview
Updates
scripts/code_health_baseline.jsonsopython scripts/code_health.py --checkmatches the repo after the Story Lab split—no thresholds or app code change.Summary counts tick up slightly (e.g. production files 458→467,
complex_functions767→771).StoryLabPanel.tsxdrops in size (7012→5389 LOC hotspot) and cyclomatic complexity (435→163);top_complexitymoves its line reference (684→466). The baseline now includes extracted Story UI modules (StoryProductionsMusicPanel,StoryProductionsTab,StoryTrailerTab,CompactVideoWorkspace,StoryMusicTab) so the ratchet stops flagging them as new hotspots.sceneRecipe.tscomplexity entry line shifts 1493→1515.Reviewed by Cursor Bugbot for commit 07d8a01. Configure here.