refactor: extraer editores compartidos de Story Lab y tabs simples con i18n - #88
Merged
Conversation
World, characters, relationships and structure import shared gallery, location, character and beat editors plus a visuals controller instead of receiving 16 component props. Visible copy on those tabs moves into the storyLab catalog (EN+ES). Music and Productions stay in the panel.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: medium Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4770902. Configure here.
Python CI still sliced StoryLabPanel for function ReferenceGallery after the shared editor extract. The confirm/modal contract now reads ReferenceGallery.tsx and asserts the panel only imports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
PR mediano cohesivo de Story Lab (siguiente corte de la cola Codex): extrae primero los componentes y el controlador visual compartidos, y luego agrupa World / Characters / Relationships / Structure en tabs que importan esos módulos. No se pasan
ReferenceGalleryniLocationEditorcomo props.Contrato
ReferenceGallery,LocationEditor,CharacterEditoryBeatEditorviven en módulos propios.StoryLabVisualsProvider+useStoryLabVisualsconcentran generate/upload/remove/imageBusy. Los tabs dejan de recibir 16 props.StoryCharactersTabyStoryStructureTabextraídos;StoryWorldTabyStoryRelationshipsTabdejan el inglés hardcoded.storyLab(EN+ES) para chrome, galería y esos cuatro tabs.Fuera de alcance
useStore.tsni_launch_runtime.py.Zona i18n
Migrada: chrome de sección (
Generate text/ Approve / hint LLM), galería de referencias, world, characters, relationships, structure y editores de location/character/beat.Queda: overview, assets, music, productions, mesa compacta, navegación interna de Story Lab.
Pruebas locales
npx tsc -b --pretty falsenpm run i18n:checknpm test(494)npx eslint . --max-warnings=0python scripts/architecture_contracts.pyNo mezclar hasta que CI esté verde.
Note
Low Risk
UI refactor and copy migration only; behavior should match prior Story Lab editing flows, with risk limited to regressions in visual upload/generate wiring via the new context.
Overview
Story Lab “simple tabs” refactor: pulls
ReferenceGallery,LocationEditor,CharacterEditor, andBeatEditorout ofStoryLabPanel, addsStoryCharactersTab/StoryStructureTab, and wires World / Characters / Relationships / Structure through sharedstoryLabEditorshelpers plusStoryLabVisualsProvider/useStoryLabVisualsso tabs no longer receive gallery components or upload/generate props as injectables.i18n: introduces the
storyLabnamespace (EN+ES) for section chrome, reference gallery, and the four foundation tabs;SectionHeader/Fieldand the i18n pilot check guard former hardcoded phrases. Music, Productions, and compact prep UI stay in the panel with mixed copy.Docs/tests: updates slice queue and i18n docs; extends
storyLabResponsiveand foundation tests for the new module layout and catalogs.Reviewed by Cursor Bugbot for commit 4770902. Configure here.