refactor: composición tipada de Zustand (sin as never) - #87
Merged
Conversation
…ther Settings owns model-visibility focus. Developer mode no longer writes mediaFilter; the facade still leaves the auditdev gallery filter.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7e65b26. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objetivo
PR de base tipada de Zustand, no una propiedad suelta.
bindSliceenui/src/stores/storeApi.ts: las slices se componen sinas neverenuseStoreopenModelVisibility)developerModeSliceya no escribemediaFilter; la fachada sigue sacando el filtroauditdeval apagar el modoSliceCreatorVerificación local
npx tsc -b --pretty falsenpm test: 492 passednpm run lint -- --max-warnings=0python scripts/architecture_contracts.pyPendiente de CI. No mezclar hasta que los checks estén verdes.
Note
Medium Risk
Touches the central
useStorecomposition path and moves cross-cutting behavior (auditdev filter reset) to the facade; behavior is covered by architecture tests but regressions would affect global UI state.Overview
Introduces
bindSliceand a sharedSliceCreatortype souseStorecomposes theme, settings, sidebar, retake, director, and developer-mode slices withoutas neverat the merge site.Settings now owns model-visibility focus (
openModelVisibility/clearModelVisibilityFocus), moving that behavior out of the monolithic store body. Developer mode no longer updatesmediaFilterinside its slice; theuseStorefacade still resetsauditdevtoallwhen developer mode is turned off.Slice modules are aligned on the same factory pattern, and
SLICE_QUEUE.mdplus architecture tests document and lock in the new binding contract.Reviewed by Cursor Bugbot for commit 7e65b26. Configure here.