Skip to content

refactor: extraer el tab World de Story Lab - #85

Merged
IAnMove merged 1 commit into
mainfrom
refactor/storylab-world-tab
Sep 2, 2026
Merged

refactor: extraer el tab World de Story Lab#85
IAnMove merged 1 commit into
mainfrom
refactor/storylab-world-tab

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Resultado

Segundo corte acotado de StoryLabPanel.tsx: solo el tab world.

  • El id del tab sigue siendo 'world'
  • El ancla id="story-review-world" y el copy visible no cambian
  • generate / approve / generateVisual se pasan igual; no hay cambio de comportamiento
  • Reutiliza storyLabChrome.tsx (sin restyle)
  • El bloque del tab vive en ui/src/features/stories/StoryWorldTab.tsx
  • LocationEditor y ReferenceGallery se quedan en el panel: CompactVideoWorkspace y characters/assets también los usan. Se pasan como props para no crear imports circulares
  • CompactVideoWorkspace conserva su propio id="story-review-world"
  • No se extraen characters / overview / music / etc.
  • No se tocan useStore.ts, catálogos i18n, model3d_service.py, rig_service.py, VideoExtraInfoDialog ni extraInfo.json

Conteos locales

  • StoryLabPanel.tsx: 7344 → 7330 líneas
  • StoryWorldTab.tsx: 96 líneas
  • diff: 3 files, +220 / −34

Verificación local

  • cd ui && npm test → 489/489
  • npm run lint -- --max-warnings=0
  • npx tsc -b --pretty false

Pendiente de CI. No mergear.


Note

Low Risk
UI-only refactor with no API or data-model changes; behavior is locked by new tests and unchanged prop callbacks.

Overview
Extracts the Story Lab “world” tab from StoryLabPanel.tsx into a new StoryWorldTab component, continuing the same pattern as other tab extractions (e.g. relationships).

Routing and UX stay the same: tab id 'world', anchor id="story-review-world", and the world-bible / locations UI still use storyLabChrome with the same patch / update / generate / approve / generateVisual wiring. ReferenceGallery and LocationEditor remain defined in the panel and are injected as props to avoid circular imports.

Adds storyLabResponsive coverage (source-structure checks plus a render test for generate, approve, world concept, upload, and add-location flows).

Reviewed by Cursor Bugbot for commit a3097a7. Configure here.

@IAnMove

IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 3 file(s); +220/-34; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/src/features/stories/StoryWorldTab.tsx
  • modified: ui/src/features/stories/StoryLabPanel.tsx, ui/tests/storyLabResponsive.test.tsx

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a3097a7. Configure here.

@IAnMove
IAnMove merged commit 1dee815 into main Sep 2, 2026
5 checks passed
@IAnMove
IAnMove deleted the refactor/storylab-world-tab branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant