refactor: extraer el tab World de Story Lab - #85
Merged
Conversation
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a3097a7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Segundo corte acotado de
StoryLabPanel.tsx: solo el tab world.'world'id="story-review-world"y el copy visible no cambiangenerate/approve/generateVisualse pasan igual; no hay cambio de comportamientostoryLabChrome.tsx(sin restyle)ui/src/features/stories/StoryWorldTab.tsxLocationEditoryReferenceGalleryse quedan en el panel: CompactVideoWorkspace y characters/assets también los usan. Se pasan como props para no crear imports circularesid="story-review-world"useStore.ts, catálogos i18n,model3d_service.py,rig_service.py, VideoExtraInfoDialog niextraInfo.jsonConteos locales
StoryLabPanel.tsx: 7344 → 7330 líneasStoryWorldTab.tsx: 96 líneasVerificación local
cd ui && npm test→ 489/489npm run lint -- --max-warnings=0npx tsc -b --pretty falsePendiente de CI. No mergear.
Note
Low Risk
UI-only refactor with no API or data-model changes; behavior is locked by new tests and unchanged prop callbacks.
Overview
Extracts the Story Lab “world” tab from
StoryLabPanel.tsxinto a newStoryWorldTabcomponent, continuing the same pattern as other tab extractions (e.g. relationships).Routing and UX stay the same: tab id
'world', anchorid="story-review-world", and the world-bible / locations UI still usestoryLabChromewith the samepatch/update/generate/approve/generateVisualwiring.ReferenceGalleryandLocationEditorremain defined in the panel and are injected as props to avoid circular imports.Adds
storyLabResponsivecoverage (source-structure checks plus a render test for generate, approve, world concept, upload, and add-location flows).Reviewed by Cursor Bugbot for commit a3097a7. Configure here.