fix: localize Video Extra info dialog copy - #82
Merged
Conversation
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7dbbe28. Configure here.
Owner
Author
|
@cursor review |
IAnMove
force-pushed
the
fix/i18n-extra-info-dialog
branch
from
September 2, 2026 12:15
7dbbe28 to
43e3860
Compare
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 43e3860. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Localiza el chrome y las etiquetas de
VideoExtraInfoDialog. No toca el inspector de Assets (ya cubierto en #77) niactivity.json.extraInfo(en/es), registrado enresources.tsy encheck-i18n-catalogs.mjsactivity.extraInfo(Extra info / Información adicional)common.actions.closeZona migrada
Cuerpo y chrome de
VideoExtraInfoDialog: Language, prompts guardados, intro, información del clip, Copiar/Generar/Regenerar, estados vacíos y errores.Deuda que permanece
Listado y toolbar de Assets, resto de paneles. No se toca init i18n ni
escapeValue.Verificación local
npm run i18n:check(6 namespaces, en/es)npm test(487)--max-warnings=0npx tsc -b --pretty falsePendiente de CI en GitHub.
No se han tocado launchers, WanGP, modelos ni
comunicaciones/.Note
Low Risk
UI-only i18n migration with no API or auth changes; behavior is equivalent aside from translated strings and localized clipboard export headers.
Overview
Adds a dedicated
extraInfotranslation namespace (English and Spanish) and wires it throughresources.tsand the i18n catalog check script.VideoExtraInfoDialogno longer hardcodes UI copy: labels, errors, loading/empty states, copy-to-clipboard strings, clip metadata export text, and publishing sections useuseUiTranslation('extraInfo'). The dialog title stays onactivity.extraInfo, and Close usescommon.actions.close. The generation-language dropdown still shows native language names.Tests and
forbiddenLiteralswere extended so pilot files cannot reintroduce strings like “Clip information” or “Wait for generation to finish”, and pluralized “saved prompts” is covered.Reviewed by Cursor Bugbot for commit 43e3860. Configure here.