Skip to content

fix: localize Video Extra info dialog copy - #82

Merged
IAnMove merged 1 commit into
mainfrom
fix/i18n-extra-info-dialog
Sep 2, 2026
Merged

fix: localize Video Extra info dialog copy#82
IAnMove merged 1 commit into
mainfrom
fix/i18n-extra-info-dialog

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Resultado

Localiza el chrome y las etiquetas de VideoExtraInfoDialog. No toca el inspector de Assets (ya cubierto en #77) ni activity.json.

  • Nuevo namespace extraInfo (en/es), registrado en resources.ts y en check-i18n-catalogs.mjs
  • El título del diálogo sigue en activity.extraInfo (Extra info / Información adicional)
  • Cerrar reutiliza common.actions.close
  • El selector de idioma de generación mantiene los nombres nativos (Español, English, Català, …)
  • Glosario: Workspace; Extra info / Información adicional

Zona migrada

Cuerpo y chrome de VideoExtraInfoDialog: Language, prompts guardados, intro, información del clip, Copiar/Generar/Regenerar, estados vacíos y errores.

Deuda que permanece

Listado y toolbar de Assets, resto de paneles. No se toca init i18n ni escapeValue.

Verificación local

  • npm run i18n:check (6 namespaces, en/es)
  • npm test (487)
  • lint --max-warnings=0
  • npx tsc -b --pretty false

Pendiente de CI en GitHub.

No se han tocado launchers, WanGP, modelos ni comunicaciones/.


Note

Low Risk
UI-only i18n migration with no API or auth changes; behavior is equivalent aside from translated strings and localized clipboard export headers.

Overview
Adds a dedicated extraInfo translation namespace (English and Spanish) and wires it through resources.ts and the i18n catalog check script.

VideoExtraInfoDialog no longer hardcodes UI copy: labels, errors, loading/empty states, copy-to-clipboard strings, clip metadata export text, and publishing sections use useUiTranslation('extraInfo'). The dialog title stays on activity.extraInfo, and Close uses common.actions.close. The generation-language dropdown still shows native language names.

Tests and forbiddenLiterals were extended so pilot files cannot reintroduce strings like “Clip information” or “Wait for generation to finish”, and pluralized “saved prompts” is covered.

Reviewed by Cursor Bugbot for commit 43e3860. Configure here.

@IAnMove

IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 6 file(s); +247/-71; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/src/i18n/locales/en/extraInfo.json, ui/src/i18n/locales/es/extraInfo.json
  • modified: ui/scripts/check-i18n-catalogs.mjs, ui/src/components/MainContent/VideoExtraInfoDialog.tsx, ui/src/i18n/resources.ts, ui/tests/i18nFoundation.test.tsx

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7dbbe28. Configure here.

@IAnMove

IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@IAnMove
IAnMove force-pushed the fix/i18n-extra-info-dialog branch from 7dbbe28 to 43e3860 Compare September 2, 2026 12:15

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 43e3860. Configure here.

@IAnMove
IAnMove merged commit 8702631 into main Sep 2, 2026
5 checks passed
@IAnMove
IAnMove deleted the fix/i18n-extra-info-dialog branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant