feat: publish asset-manifest v1 from editor and scene-recording sidecars - #78
Merged
Merged
Conversation
Gallery sidecars for scene recording, Video Editor screenshot/export, and comic animatic keep their legacy keys and now write the canonical document through publish_generation_sidecar, without inventing actor.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a7a7473. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente writer de manifiesto: los cuatro sidecars de galería que quedaban en
_launch_runtime.py(grabación 3D, captura del editor, export del editor y animatic de cómic). PR único que toca_launch_runtime.py, ramificado desdeorigin/main, no apilado.publish_generation_sidecardesde helpers extraídos (import interno, como Recast)params,job_id,task_id,root_task_id,generation_mode,tool,workspace, timings)origin.tool=scene-animator-3d/video-editor-screenshot/video-editor/comic-animaticorigin.actor=unknown(no se pasa ni se inventa actor)workspace_idsale dedetails.workspace,body.workspaceo el workspace del job_remove_video_editor_output_bundlesigue borrando.meta.json.civitai.json, blend/copy de meta, ni writers ya en v1asset_manifest.py,useStore.ts, Director, MiniMax, Series, 3D, Rig, alternative_songs ni i18nVerificación local
test_execution_mode+test_video_editor_scheduler_jobs+test_video_editor_animatic+test_scene_recording+test_asset_manifest+test_architecture_contracts: 60 passedarchitecture_contracts.py: OKverify_clean_repo.py: OKPendiente de CI.
@cursor reviewsobre este HEAD.Note
Medium Risk
Touches gallery metadata for multiple user-facing export paths in a very large runtime file; behavior should be equivalent for legacy keys but manifest shape and asset IDs now follow the shared publisher.
Overview
Routes the last four gallery metadata writers in
_launch_runtime.pythroughpublish_generation_sidecarinstead of writing raw.meta.jsonwithjson.dump.Scene 3D recordings, video-editor frame captures, timeline exports, and comic animatics each get a small helper that publishes a canonical asset-manifest v1 sidecar while keeping existing gallery fields (
params, job/task IDs,generation_mode, timings).origin.toolis set per flow (scene-animator-3d,video-editor-screenshot,video-editor,comic-animatic);origin.actorstaysunknown(no invented user). Workspace comes from recording details, request body, or the editor job.Tests add parametrized coverage for all four writers plus scheduler-job assertions on
schemaandorigin, and extend the launch-runtime contract so these helpers usepublish_generation_sidecarand not directjson.dump.Reviewed by Cursor Bugbot for commit a7a7473. Configure here.