Skip to content

feat: publish asset-manifest v1 from editor and scene-recording sidecars - #78

Merged
IAnMove merged 1 commit into
mainfrom
feat/editor-outputs-asset-manifest
Sep 2, 2026
Merged

feat: publish asset-manifest v1 from editor and scene-recording sidecars#78
IAnMove merged 1 commit into
mainfrom
feat/editor-outputs-asset-manifest

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Resultado

Siguiente writer de manifiesto: los cuatro sidecars de galería que quedaban en _launch_runtime.py (grabación 3D, captura del editor, export del editor y animatic de cómic). PR único que toca _launch_runtime.py, ramificado desde origin/main, no apilado.

  • reutiliza publish_generation_sidecar desde helpers extraídos (import interno, como Recast)
  • conserva las claves de galería (params, job_id, task_id, root_task_id, generation_mode, tool, workspace, timings)
  • origin.tool = scene-animator-3d / video-editor-screenshot / video-editor / comic-animatic
  • origin.actor = unknown (no se pasa ni se inventa actor)
  • workspace_id sale de details.workspace, body.workspace o el workspace del job
  • si falla el sidecar de scene recording, se sigue borrando el MP4
  • _remove_video_editor_output_bundle sigue borrando .meta.json
  • no convierte dumps .civitai.json, blend/copy de meta, ni writers ya en v1
  • no toca asset_manifest.py, useStore.ts, Director, MiniMax, Series, 3D, Rig, alternative_songs ni i18n

Verificación local

  • pytest test_execution_mode + test_video_editor_scheduler_jobs + test_video_editor_animatic + test_scene_recording + test_asset_manifest + test_architecture_contracts: 60 passed
  • architecture_contracts.py: OK
  • verify_clean_repo.py: OK

Pendiente de CI. @cursor review sobre este HEAD.


Note

Medium Risk
Touches gallery metadata for multiple user-facing export paths in a very large runtime file; behavior should be equivalent for legacy keys but manifest shape and asset IDs now follow the shared publisher.

Overview
Routes the last four gallery metadata writers in _launch_runtime.py through publish_generation_sidecar instead of writing raw .meta.json with json.dump.

Scene 3D recordings, video-editor frame captures, timeline exports, and comic animatics each get a small helper that publishes a canonical asset-manifest v1 sidecar while keeping existing gallery fields (params, job/task IDs, generation_mode, timings). origin.tool is set per flow (scene-animator-3d, video-editor-screenshot, video-editor, comic-animatic); origin.actor stays unknown (no invented user). Workspace comes from recording details, request body, or the editor job.

Tests add parametrized coverage for all four writers plus scheduler-job assertions on schema and origin, and extend the launch-runtime contract so these helpers use publish_generation_sidecar and not direct json.dump.

Reviewed by Cursor Bugbot for commit a7a7473. Configure here.

Gallery sidecars for scene recording, Video Editor screenshot/export, and
comic animatic keep their legacy keys and now write the canonical document
through publish_generation_sidecar, without inventing actor.
@IAnMove

IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 3 file(s); +200/-31

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • No heuristic issues. Still run the CI checklist below.

Changed files

  • modified: app/_launch_runtime.py, tests/test_execution_mode.py, tests/test_video_editor_scheduler_jobs.py

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a7a7473. Configure here.

@IAnMove
IAnMove merged commit 0fe0d63 into main Sep 2, 2026
5 checks passed
@IAnMove
IAnMove deleted the feat/editor-outputs-asset-manifest branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant