feat: publish asset-manifest v1 from alternative-song sidecars - #76
Merged
Conversation
Parent gallery mutations keep asset.id and origin.tool. Remounted outputs publish with tool=alternative-songs and workspace from the caller. Actor stays unknown; API keys are not persisted.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 097cc6b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente writer de manifiesto: solo las sidecars de canciones alternativas (
app/services/alternative_songs.py). PR único ramificado desdeorigin/main, no apilado.save_sidecarreutilizapublish_generation_sidecarsobre la ruta de media, no el.meta.jsonparams.alternative_songsy el resto de claves de galeríaasset.idyorigin.tool(series-assembly/director/studio no se reescriben)write_mounted_sidecarpublica contool=alternative-songsyworkspace_iddel argumentounknown); no se inventauserni workspacedefault_launch_runtime.py, WanGP, models, Director, Series, 3D, Rig, i18n niasset_manifest.pyVerificación local
test_alternative_songs+test_asset_manifest+test_architecture_contracts: 35 passedtests/test_alternative_songs.py: 13tests/test_asset_manifest.py: 17tests/test_architecture_contracts.py: 5scripts/architecture_contracts.py: OKscripts/verify_clean_repo.py: OKPendiente de CI.
@cursor reviewsobre este HEAD.Note
Medium Risk
Changes how gallery sidecars are persisted and attributed for alternative-song flows; mistakes could corrupt origin/tool or asset IDs, but scope is limited to
alternative_songs.pywith targeted tests.Overview
Alternative-song gallery metadata no longer writes raw
.meta.jsonwith a local atomic dump;save_sidecarnow routes throughpublish_generation_sidecarso sidecars get the v1schema, redaction, and canonicaloriginfields while keeping legacy keys likeparams.alternative_songs.Tool and workspace attribution are resolved carefully: an explicit
toolargument wins; otherwise existing v1origin.toolon disk or in the payload is kept (so series-assembly / director / studio are not overwritten). Director-only pipeline IDs leavetoolunset so publish can attribute director. Workspace comes fromworkspace/workspace_idwithout defaulting todefault.write_mounted_sidecarnow passestool="alternative-songs"on save (including the follow-up save whenresult_kindis corrected).New tests cover v1 publish roundtrip, stable
asset.id, preserved series-assembly origin, mounted outputs withalternative-songsorigin, secret stripping, andactorunknown(not inventeduser).Reviewed by Cursor Bugbot for commit 097cc6b. Configure here.