refactor: extract the developer-mode slice from useStore - #75
Merged
Conversation
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0647cd2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente corte acotado de
useStore:createDeveloperModeSliceenui/src/stores/developerModeSlice.ts.useStore.tssigue siendo la fachada pública (developerMode,setDeveloperMode)hocuspocus-developer-mode-v1sin cambio (loadDeveloperMode/saveDeveloperMode)mediaFiltersigue enuseStore; al desactivar developer mode con filtroauditdevse restablece aallagentActions.ts, Python ni_launch_runtime.pyuseStore.tsVerificación local
npx tsx --tsconfig tsconfig.app.json --import ./tests/setupI18n.ts --test tests/architectureSlices.test.mjs7/7npm test485--max-warnings=0tsc -bpython scripts/architecture_contracts.pyPendiente de CI.
Note
Low Risk
Refactor-only with parity tests; no API or persistence contract changes beyond relocating slice code.
Overview
Moves developer mode state and
setDeveloperModeout ofuseStore.tsinto a dedicatedcreateDeveloperModeSlicemodule, matching the existing theme/settings slice pattern.useStoreremains the public facade by spreading the slice at store creation.Behavior is intentionally unchanged: the flag still loads and saves via
loadDeveloperMode/saveDeveloperMode(hocuspocus-developer-mode-v1), and turning off developer mode still resetsmediaFilterfromauditdevtoallwhile leaving other filters untouched.Adds an architecture test that exercises persistence through the slice alone and through
useStore, including theauditdev→alltransition.Reviewed by Cursor Bugbot for commit 0647cd2. Configure here.