feat: publish asset-manifest v1 when Director attaches output timing - #74
Merged
Conversation
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 581fa0a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente writer de manifiesto: solo el mutador de timings del sidecar de salida Director (
persist_pipeline_output_timing). PR único ramificado desdeorigin/main, no apilado.publish_generation_sidecarsobre la ruta del fichero de media, no del sidecargeneration_time,generation_timings,director_pipeline_id,params) junto al documento canónicoorigin.tool=director;origin.actor=unknown(no se pasa ni se inventa actor)workspace_idsale depipeline.get("workspace"); no se inventa workspace"default"publish_generation_sidecarconservaasset.idcanónico vía_existing_canonical_asset_id(no se emite un ID nuevo al adjuntar timings)enrich_output_metadata_with_pipeline_timingno cambia_write_director_assembly_sidecarno se toca (ya era v1)_launch_runtime.py, WanGP, models, Recast/Repaint/Outpaint, Tools, MiniMax image, Series, 3D, Rig,useStore.ts, i18n niasset_manifest.pyVerificación local
test_director_pipeline_timing+test_asset_manifest+test_architecture_contracts: 31 passedarchitecture_contracts.py: OKverify_clean_repo.py: OKPendiente de CI.
@cursor reviewsobre este HEAD.Note
Medium Risk
Changes how Director output sidecars are written and ties them to the shared asset-manifest path, which gallery and manifest readers depend on; scope is limited to
persist_pipeline_output_timingvia an existing publisher.Overview
Director final output timing no longer writes
*.meta.jsonvia a temp file andos.replace; it now callspublish_generation_sidecaron the media path (e.g.final.mp4) with enriched timing metadata,tool="director", andworkspace_idfrom the pipeline.Legacy timing fields (
generation_time,generation_timings,director_pipeline_id,params, etc.) stay on the sidecar alongside the canonical v1 manifest (schema,asset,origin). Re-running timing persistence should keep the sameasset.idwhen a manifest already exists.Tests assert the v1 shape (
schema,origin.tool/origin.actor) on timing save and add coverage for stable asset ID across repeatedpersist_pipeline_output_timingcalls.Reviewed by Cursor Bugbot for commit 581fa0a. Configure here.