feat: publish asset-manifest v1 from Director H3 join sidecars - #73
Merged
Conversation
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ccd6505. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente writer de manifiesto: solo el sidecar de ensamblado secuencial Director MiniMax H3 (
_run_minimax_h3_story_video→_write_director_assembly_sidecar). PR único de writer para Director-join, ramificado desdeorigin/main, no apilado.publish_generation_sidecarparamscondirector_pipeline_id,generation_mode,result_kind,created_at)origin.tool=director;origin.actor=unknown(no se pasa ni se inventa actor)workspace_idsale del argumentoworkspacede_run_minimax_h3_story_video; no se inventa workspacepersist_pipeline_output_timingsigue usandojson.dump(muta un sidecar existente)_launch_runtime.py, WanGP, models, Recast/Repaint/Outpaint, Tools, MiniMax image, Series assembly, 3D, Rig,useStore.tsniasset_manifest.pyVerificación local
test_director_pipeline_timing+test_asset_manifest+test_architecture_contracts: 30 passedarchitecture_contracts.py: OKverify_clean_repo.py: OKPendiente de CI.
@cursor reviewsobre este HEAD.Note
Medium Risk
Changes persisted metadata for assembled Director deliverables; behavior is covered by tests and legacy top-level keys are retained, but any consumer assuming only the old unstructured sidecar shape could be affected.
Overview
Director sequential MiniMax H3 join no longer writes assembly metadata with a raw
json.dumpto.meta.json. It now goes through_write_director_assembly_sidecar, which callspublish_generation_sidecarwithtool="director"and the pipelineworkspaceid.The sidecar payload (
params,generation_mode,result_kind,created_at, etc.) is still present for gallery-style readers, but the on-disk file is a canonical asset-manifest v1 document (schema,origin,execution, stableasset.idon re-publish for the same output path). Sensitive fields likeapi_keyare not written to the published manifest.persist_pipeline_output_timingand other timing sidecar updates are unchanged (still direct JSON mutation). A new test intest_director_pipeline_timing.pylocks in schema, origin/execution fields, secret stripping, and asset id stability.Reviewed by Cursor Bugbot for commit ccd6505. Configure here.