feat: publish asset-manifest v1 from 3D and Rig sidecars - #72
Merged
Conversation
Hunyuan3D and Rig completed-job sidecars keep gallery keys and now write the canonical document without inventing actor or workspace.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a2249f0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente writer de manifiesto: solo Hunyuan3D y Rig (
app/services/model3d_service.py,app/services/rig_service.py). PR único de writer para model3d+rig, ramificado desdeorigin/main, no apilado.publish_generation_sidecargeneration_mode,mode,job_id,task_id,root_task_id,created_at,params)origin.tool=model3d/rig;origin.actor=unknown(no se pasa ni se inventa actor)workspace_idsale del job en memoria (job.get("workspace")); no se inventa workspace_cleanup_partial_outputsigue borrando.meta.jsonrequest_pathdel worker sigue siendojson.dumps; no es sidecar de galería_launch_runtime.py, WanGP, models, Director, recipes, video editor, i18n niasset_manifest.pyVerificación local
test_model3d_rig_task_identity+test_asset_manifest+test_architecture_contracts: 24 passedarchitecture_contracts.py: OKverify_clean_repo.py: OKPendiente de CI.
@cursor reviewsobre este HEAD.Note
Low Risk
Localized change to post-success metadata writes; generation, worker I/O, and partial-output cleanup are unchanged.
Overview
Hunyuan3D and rig completion paths now write gallery sidecars through
publish_generation_sidecarinstead of hand-written.meta.jsondumps.The same legacy gallery fields (
generation_mode,job_id,task_id,params, etc.) are still passed in; the helper adds the asset-manifest v1 envelope (e.g.schema) andoriginmetadata withtoolset tomodel3dorrig,actordefaulting tounknown, andworkspace_idtaken from the in-memory job’sworkspace.Tests in
test_model3d_rig_task_identitynow assert the schema name and thatread_asset_manifestsees the expectedoriginfor each workspace.Reviewed by Cursor Bugbot for commit a2249f0. Configure here.