Skip to content

feat: publish asset-manifest v1 from 3D and Rig sidecars - #72

Merged
IAnMove merged 1 commit into
mainfrom
feat/model3d-rig-asset-manifest
Sep 2, 2026
Merged

feat: publish asset-manifest v1 from 3D and Rig sidecars#72
IAnMove merged 1 commit into
mainfrom
feat/model3d-rig-asset-manifest

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Resultado

Siguiente writer de manifiesto: solo Hunyuan3D y Rig (app/services/model3d_service.py, app/services/rig_service.py). PR único de writer para model3d+rig, ramificado desde origin/main, no apilado.

  • reutiliza publish_generation_sidecar
  • conserva las claves de galería (generation_mode, mode, job_id, task_id, root_task_id, created_at, params)
  • origin.tool = model3d / rig; origin.actor = unknown (no se pasa ni se inventa actor)
  • workspace_id sale del job en memoria (job.get("workspace")); no se inventa workspace
  • _cleanup_partial_output sigue borrando .meta.json
  • el request_path del worker sigue siendo json.dumps; no es sidecar de galería
  • no toca _launch_runtime.py, WanGP, models, Director, recipes, video editor, i18n ni asset_manifest.py

Verificación local

  • pytest test_model3d_rig_task_identity + test_asset_manifest + test_architecture_contracts: 24 passed
  • architecture_contracts.py: OK
  • verify_clean_repo.py: OK

Pendiente de CI. @cursor review sobre este HEAD.


Note

Low Risk
Localized change to post-success metadata writes; generation, worker I/O, and partial-output cleanup are unchanged.

Overview
Hunyuan3D and rig completion paths now write gallery sidecars through publish_generation_sidecar instead of hand-written .meta.json dumps.

The same legacy gallery fields (generation_mode, job_id, task_id, params, etc.) are still passed in; the helper adds the asset-manifest v1 envelope (e.g. schema) and origin metadata with tool set to model3d or rig, actor defaulting to unknown, and workspace_id taken from the in-memory job’s workspace.

Tests in test_model3d_rig_task_identity now assert the schema name and that read_asset_manifest sees the expected origin for each workspace.

Reviewed by Cursor Bugbot for commit a2249f0. Configure here.

Hunyuan3D and Rig completed-job sidecars keep gallery keys and now
write the canonical document without inventing actor or workspace.
@IAnMove

IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 3 file(s); +61/-56; backend services

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • No heuristic issues. Still run the CI checklist below.

Changed files

  • modified: app/services/model3d_service.py, app/services/rig_service.py, tests/test_model3d_rig_task_identity.py

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a2249f0. Configure here.

@IAnMove
IAnMove merged commit 17f8f29 into main Sep 2, 2026
4 of 5 checks passed
@IAnMove
IAnMove deleted the feat/model3d-rig-asset-manifest branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant