feat: publish asset-manifest v1 for Series episode assembly - #71
Merged
Conversation
Joined Series episode files keep seriesId/episodeId in gallery params and now write the canonical sidecar without inventing actor.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2e32862. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente writer de manifiesto: solo el sidecar de ensamblado de episodios de Series (
app/routers/series_assembly.py).publish_generation_sidecarparams.seriesId/episodeId/assemblyJobIdpara la galeríaunknown); tool =series-assemblyactor; no se inventa_remove_assembly_artifactssigue borrando el sidecar consplitext+.meta.json_launch_runtime.py, WanGP, models, agentActions, useStore, i18n niasset_manifest.pyVerificación local
test_series_assembly_router+test_series_assembly+test_series_assembly_contract: 14 passedarchitecture_contracts.py: OKverify_clean_repo.py: OKPendiente de CI.
@cursor reviewsobre este HEAD.Note
Low Risk
Scoped to sidecar metadata for series assembly outputs; behavior for join/cancel/cleanup is unchanged aside from manifest format.
Overview
Series episode assembly now writes canonical asset-manifest v1 sidecars instead of hand-rolled JSON after FFmpeg joins clips.
A new
_write_assembly_sidecardelegates topublish_generation_sidecarwithtool="series-assembly", workspace from the job, and the same gallery-facingparams(seriesId,episodeId,assemblyJobId). Noactoris passed, so origin staysunknownrather than invented. Cleanup via_remove_assembly_artifactsis unchanged.Tests assert the completed join path and the helper emit
SCHEMA_NAME, load correctly throughread_asset_manifest, and recordorigin.tool/origin.actoras expected.Reviewed by Cursor Bugbot for commit 2e32862. Configure here.