refactor: extract the settings drawer slice from useStore - #70
Merged
Conversation
Settings open/tab stay on the public useStore facade with the same in-memory behavior. Theme, Story, Series and Comics are untouched.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c950f9d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente corte acotado de
useStore:createSettingsSliceenui/src/stores/settingsSlice.ts.useStore.tssigue siendo la fachada pública (settingsOpen,toggleSettings,setSettingsOpen,settingsTab,setSettingsTab)openModelVisibilitysigue enuseStorey escribe los mismos camposagentActions.ts, Python ni_launch_runtime.pyuseStore.tsVerificación local
npx tsx --tsconfig tsconfig.app.json --import ./tests/setupI18n.ts --test tests/architectureSlices.test.mjs6/6npm test484--max-warnings=0tsc -bpython scripts/architecture_contracts.pyPendiente de CI.
Note
Low Risk
In-memory UI state refactor with no API or persistence changes; behavior is covered by existing and new slice tests.
Overview
Moves settings drawer UI state out of the monolithic
useStoreinto a dedicatedcreateSettingsSlicemodule, following the same pattern asthemeSliceanddirectorSlice.The slice owns
settingsOpen/toggleSettings/setSettingsOpenandsettingsTab/setSettingsTab(default tab remainsperformance).useStorestill spreads the slice so the public API and selectors stay the same; nothing is persisted.Adds an architecture test that exercises the slice in isolation and through
useStore.getState(), consistent with other slice facade tests.Reviewed by Cursor Bugbot for commit c950f9d. Configure here.