feat: publish asset-manifest v1 for MiniMax images - #68
Merged
Conversation
MiniMax Image-01 sidecars keep gallery params and now write the canonical document without storing the API key or inventing actor.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1ccc7c6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente writer de manifiesto: solo MiniMax Image-01 (
app/services/minimax_image_service.py).publish_generation_sidecargeneration_mode,task_id,root_task_id,params,created_at)origin.tool=minimax-image;origin.actor=unknown(no se pasa ni se inventa actor)api_keygenerate_imageno tieneworkspace_id; se omite_launch_runtime.py, WanGP ni otros writersminimax_image_service.pyytests/test_minimax_image_service.pyVerificación local
test_minimax_image_service+test_asset_manifest: 20 passedarchitecture_contracts.py: OKverify_clean_repo.py: OKPendiente de CI.
@cursor reviewsobre este HEAD.Note
Low Risk
Scoped to MiniMax image persistence metadata; behavior for callers is unchanged aside from richer manifest sidecars, with tests covering the new format.
Overview
MiniMax Image-01 now writes generation metadata through
publish_generation_sidecarinstead of hand-rolling a.meta.jsonfile withjson.dump. Image bytes are still saved atomically; only the sidecar path goes through the shared asset-manifest helper.The sidecar payload keeps the same gallery-facing keys (
generation_mode,task_id,root_task_id,params,created_at) and still omits secrets.origin.toolis set tominimax-imagewithorigin.actorleft asunknown(no actor is passed fromgenerate_image).Tests assert the canonical
hocuspocus.asset-manifestdocument viaread_asset_manifest, in addition to the existing.meta.jsonchecks.Reviewed by Cursor Bugbot for commit 1ccc7c6. Configure here.