Skip to content

feat: publish asset-manifest v1 for MiniMax images - #68

Merged
IAnMove merged 1 commit into
mainfrom
feat/minimax-image-asset-manifest
Sep 2, 2026
Merged

feat: publish asset-manifest v1 for MiniMax images#68
IAnMove merged 1 commit into
mainfrom
feat/minimax-image-asset-manifest

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Resultado

Siguiente writer de manifiesto: solo MiniMax Image-01 (app/services/minimax_image_service.py).

  • reutiliza publish_generation_sidecar
  • conserva las claves de galería (generation_mode, task_id, root_task_id, params, created_at)
  • origin.tool = minimax-image; origin.actor = unknown (no se pasa ni se inventa actor)
  • no persiste api_key
  • generate_image no tiene workspace_id; se omite
  • los bytes de la imagen siguen escribiéndose de forma atómica; el sidecar lo escribe el helper
  • no toca Director, _launch_runtime.py, WanGP ni otros writers
  • archivos únicos: minimax_image_service.py y tests/test_minimax_image_service.py

Verificación local

  • pytest test_minimax_image_service + test_asset_manifest: 20 passed
  • architecture_contracts.py: OK
  • verify_clean_repo.py: OK

Pendiente de CI. @cursor review sobre este HEAD.


Note

Low Risk
Scoped to MiniMax image persistence metadata; behavior for callers is unchanged aside from richer manifest sidecars, with tests covering the new format.

Overview
MiniMax Image-01 now writes generation metadata through publish_generation_sidecar instead of hand-rolling a .meta.json file with json.dump. Image bytes are still saved atomically; only the sidecar path goes through the shared asset-manifest helper.

The sidecar payload keeps the same gallery-facing keys (generation_mode, task_id, root_task_id, params, created_at) and still omits secrets. origin.tool is set to minimax-image with origin.actor left as unknown (no actor is passed from generate_image).

Tests assert the canonical hocuspocus.asset-manifest document via read_asset_manifest, in addition to the existing .meta.json checks.

Reviewed by Cursor Bugbot for commit 1ccc7c6. Configure here.

MiniMax Image-01 sidecars keep gallery params and now write the
canonical document without storing the API key or inventing actor.
@IAnMove

IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 2 file(s); +14/-6; backend services

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • No heuristic issues. Still run the CI checklist below.

Changed files

  • modified: app/services/minimax_image_service.py, tests/test_minimax_image_service.py

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1ccc7c6. Configure here.

@IAnMove
IAnMove merged commit b6e2893 into main Sep 2, 2026
5 checks passed
@IAnMove
IAnMove deleted the feat/minimax-image-asset-manifest branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant