Skip to content

refactor: move Story and Series UI-bus listeners off Agent Mode #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IAnMove merged 2 commits into from
Sep 1, 2026
Merged

refactor: move Story and Series UI-bus listeners off Agent Mode #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce8bf90
refactor: move Story and Series UI-bus listeners off Agent Mode
IAnMove Sep 1, 2026
1fd1e4b
Merge remote-tracking branch 'origin/main' into refactor/paso3-ui-bus
IAnMove Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
355 changes: 1 addition & 354 deletions ui/src/features/agent/agentUiBus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,354 +1 @@
import type { SeriesJobStatus } from '../series/types'
import type { SeriesAssemblyJob } from '../series/assemblyContract'

export type AgentStorySection = 'overview' | 'assets' | 'world' | 'characters' | 'relationships' | 'structure' | 'music' | 'trailer' | 'productions' | 'assembly'
export type AgentSeriesSection = 'setup' | 'canon' | 'episode' | 'shots' | 'review'
export type AgentSeriesReviewView = 'assembly' | 'history' | 'finish'

const STORY_SECTION_EVENT = 'hocuspocus:story-section'
const SERIES_SECTION_EVENT = 'hocuspocus:series-section'
const STORY_DRAFT_EVENT = 'hocuspocus:story-draft-ready'
const SERIES_PLAN_JOB_EVENT = 'hocuspocus:series-plan-job'
const SERIES_RENDER_JOB_EVENT = 'hocuspocus:series-render-job'
const SERIES_ASSEMBLY_JOB_EVENT = 'hocuspocus:series-assembly-job'
const SERIES_REVIEW_VIEW_EVENT = 'hocuspocus:series-review-view'
let requestedStorySection: AgentStorySection | null = null
let requestedSeriesSection: AgentSeriesSection | null = null
let requestedSeriesPlanJob: SeriesJobStatus | null = null
let requestedSeriesRenderJob: SeriesJobStatus | null = null
let requestedSeriesAssemblyJob: SeriesAssemblyJob | null = null
let requestedSeriesReviewView: AgentSeriesReviewView | null = null

export interface AgentStoryVisualGenerationRequest {
projectId: string
scope: 'world' | 'locations' | 'characters' | 'all'
targetNames: string[]
}

export interface AgentStoryVisualGenerationResult {
message: string
assetIds: string[]
}

interface PendingStoryVisualGenerationRequest {
request: AgentStoryVisualGenerationRequest
resolve: (result: AgentStoryVisualGenerationResult) => void
reject: (error: Error) => void
}

const STORY_VISUAL_GENERATION_EVENT = 'hocuspocus:story-visual-generation'
const pendingStoryVisualGenerationRequests: PendingStoryVisualGenerationRequest[] = []

export function requestAgentStoryVisualGeneration(request: AgentStoryVisualGenerationRequest): Promise<AgentStoryVisualGenerationResult> {
return new Promise((resolve, reject) => {
pendingStoryVisualGenerationRequests.push({ request, resolve, reject })
window.dispatchEvent(new CustomEvent(STORY_VISUAL_GENERATION_EVENT))
})
}

export function listenForAgentStoryVisualGeneration(
listener: (request: AgentStoryVisualGenerationRequest) => Promise<AgentStoryVisualGenerationResult>,
): () => void {
let active = true
const drain = async () => {
while (active && pendingStoryVisualGenerationRequests.length) {
const pending = pendingStoryVisualGenerationRequests.shift()
if (!pending) continue
try { pending.resolve(await listener(pending.request)) }
catch (error) { pending.reject(error instanceof Error ? error : new Error(String(error))) }
}
}
const handler = () => { void drain() }
window.addEventListener(STORY_VISUAL_GENERATION_EVENT, handler)
void drain()
return () => { active = false; window.removeEventListener(STORY_VISUAL_GENERATION_EVENT, handler) }
}

export type AgentSceneControlRequest =
| { type: 'open_3d_scene'; sceneName: string; layerName: string }
| { type: 'save_3d_scene'; sceneName: string }
| { type: 'export_3d_scene'; sceneName: string }

export type AgentSceneWorkflowRequest =
| { type: 'create_3d_scene'; sceneName: string; durationSeconds: number; width: number; height: number; fps: 30 | 60; reset?: boolean }
| { type: 'set_3d_scene_properties'; sceneName: string; durationSeconds?: number; width?: number; height?: number; fps?: 30 | 60 }
| { type: 'add_3d_scene_layer'; sceneName: string; layerName: string; layerType: 'model3d' | 'image' | 'video' | 'overlay' | 'camera'; outputName?: string }
| { type: 'update_3d_scene_layer'; sceneName: string; layerName: string; visible?: boolean; locked?: boolean }
| { type: 'remove_3d_scene_layer'; sceneName: string; layerName: string }
| { type: 'attach_3d_scene_audio'; sceneName: string; audioOutputName: string }
| { type: 'analyze_3d_scene_audio'; sceneName: string; audioOutputName: string }
| { type: 'apply_3d_choreography'; sceneName: string; layerName: string; audioOutputName: string; cueSource: 'beats' | 'downbeats'; profile: 'pulse' | 'bounce' | 'peek' | 'camera-punch'; intensity: number; rhythmGrid?: AgentRhythmGrid }
| AgentSceneControlRequest

export interface AgentSceneWorkflowResult {
message: string
sceneId?: string
layerIds?: string[]
audioTrackId?: string
analysisId?: string
bpm?: number
beatCount?: number
downbeatCount?: number
outputNames?: string[]
rhythmGrid?: AgentRhythmGrid
}

export interface AgentRhythmGrid {
duration: number
bpm: number
beats: Array<{ time: number; strength: number }>
downbeats: number[]
}

interface PendingSceneWorkflowRequest {
request: AgentSceneWorkflowRequest
resolve: (result: AgentSceneWorkflowResult) => void
reject: (error: Error) => void
}

const SCENE_WORKFLOW_REQUEST_EVENT = 'hocuspocus:scene-workflow-request'
const pendingSceneWorkflowRequests: PendingSceneWorkflowRequest[] = []

export function requestAgentSceneWorkflow(request: AgentSceneWorkflowRequest): Promise<AgentSceneWorkflowResult> {
return new Promise((resolve, reject) => {
pendingSceneWorkflowRequests.push({ request, resolve, reject })
window.dispatchEvent(new CustomEvent(SCENE_WORKFLOW_REQUEST_EVENT))
})
}

export function listenForAgentSceneWorkflow(
listener: (request: AgentSceneWorkflowRequest) => Promise<AgentSceneWorkflowResult>,
): () => void {
let active = true
const drain = async () => {
while (active && pendingSceneWorkflowRequests.length) {
const pending = pendingSceneWorkflowRequests.shift()
if (!pending) continue
try { pending.resolve(await listener(pending.request)) }
catch (error) { pending.reject(error instanceof Error ? error : new Error(String(error))) }
}
}
const handler = () => { void drain() }
window.addEventListener(SCENE_WORKFLOW_REQUEST_EVENT, handler)
void drain()
return () => { active = false; window.removeEventListener(SCENE_WORKFLOW_REQUEST_EVENT, handler) }
}

interface PendingSceneControlRequest {
request: AgentSceneControlRequest
resolve: (message: string) => void
reject: (error: Error) => void
}

const SCENE_CONTROL_REQUEST_EVENT = 'hocuspocus:scene-control-request'
const pendingSceneControlRequests: PendingSceneControlRequest[] = []

export function requestAgentSceneControl(request: AgentSceneControlRequest): Promise<string> {
return new Promise((resolve, reject) => {
pendingSceneControlRequests.push({ request, resolve, reject })
window.dispatchEvent(new CustomEvent(SCENE_CONTROL_REQUEST_EVENT))
})
}

export function listenForAgentSceneControl(
listener: (request: AgentSceneControlRequest) => Promise<string>,
): () => void {
let active = true
const drain = async () => {
while (active && pendingSceneControlRequests.length) {
const pending = pendingSceneControlRequests.shift()
if (!pending) continue
try { pending.resolve(await listener(pending.request)) }
catch (error) { pending.reject(error instanceof Error ? error : new Error(String(error))) }
}
}
const handler = () => { void drain() }
window.addEventListener(SCENE_CONTROL_REQUEST_EVENT, handler)
void drain()
return () => { active = false; window.removeEventListener(SCENE_CONTROL_REQUEST_EVENT, handler) }
}

export interface AgentSceneRhythmRequest {
sceneName: string
layerName: string
audioOutputName: string
cueSource: 'beats' | 'downbeats'
profile: 'pulse' | 'bounce' | 'peek' | 'camera-punch'
intensity: number
}

interface PendingSceneRhythmRequest {
request: AgentSceneRhythmRequest
resolve: (message: string) => void
reject: (error: Error) => void
}

const SCENE_RHYTHM_REQUEST_EVENT = 'hocuspocus:scene-rhythm-request'
const pendingSceneRhythmRequests: PendingSceneRhythmRequest[] = []

export function requestAgentSceneRhythm(request: AgentSceneRhythmRequest): Promise<string> {
return new Promise((resolve, reject) => {
const pending = { request, resolve, reject }
pendingSceneRhythmRequests.push(pending)
window.dispatchEvent(new CustomEvent(SCENE_RHYTHM_REQUEST_EVENT))
})
}

export function listenForAgentSceneRhythm(
listener: (request: AgentSceneRhythmRequest) => Promise<string>,
): () => void {
let active = true
const drain = async () => {
while (active && pendingSceneRhythmRequests.length) {
const pending = pendingSceneRhythmRequests.shift()
if (!pending) continue
try { pending.resolve(await listener(pending.request)) }
catch (error) { pending.reject(error instanceof Error ? error : new Error(String(error))) }
}
}
const handler = () => { void drain() }
window.addEventListener(SCENE_RHYTHM_REQUEST_EVENT, handler)
void drain()
return () => { active = false; window.removeEventListener(SCENE_RHYTHM_REQUEST_EVENT, handler) }
}

export function openAgentStorySection(section: AgentStorySection): void {
requestedStorySection = section
window.dispatchEvent(new CustomEvent(STORY_SECTION_EVENT, { detail: { section } }))
}

export function openAgentSeriesSection(section: AgentSeriesSection): void {
requestedSeriesSection = section
window.dispatchEvent(new CustomEvent(SERIES_SECTION_EVENT, { detail: { section } }))
}

export function listenForAgentStorySection(
listener: (section: AgentStorySection) => void,
): () => void {
const handler = (event: Event) => {
const section = (event as CustomEvent<{ section?: AgentStorySection }>).detail?.section
if (section) listener(section)
}
window.addEventListener(STORY_SECTION_EVENT, handler)
if (requestedStorySection) listener(requestedStorySection)
return () => window.removeEventListener(STORY_SECTION_EVENT, handler)
}

export function listenForAgentSeriesSection(
listener: (section: AgentSeriesSection) => void,
): () => void {
const handler = (event: Event) => {
const section = (event as CustomEvent<{ section?: AgentSeriesSection }>).detail?.section
if (section) listener(section)
}
window.addEventListener(SERIES_SECTION_EVENT, handler)
if (requestedSeriesSection) listener(requestedSeriesSection)
return () => window.removeEventListener(SERIES_SECTION_EVENT, handler)
}

export function notifyAgentStoryDraft(projectId: string): void {
window.dispatchEvent(new CustomEvent(STORY_DRAFT_EVENT, { detail: { projectId } }))
}

export function listenForAgentStoryDraft(listener: (projectId: string) => void): () => void {
const handler = (event: Event) => {
const projectId = (event as CustomEvent<{ projectId?: string }>).detail?.projectId
if (projectId) listener(projectId)
}
window.addEventListener(STORY_DRAFT_EVENT, handler)
return () => window.removeEventListener(STORY_DRAFT_EVENT, handler)
}

export function notifyAgentSeriesPlanJob(job: SeriesJobStatus): void {
requestedSeriesPlanJob = job
window.dispatchEvent(new CustomEvent(SERIES_PLAN_JOB_EVENT, { detail: { job, episodeId: job.episodeId } }))
}

export function clearAgentSeriesPlanJob(episodeId: string): void {
if (requestedSeriesPlanJob?.episodeId === episodeId) requestedSeriesPlanJob = null
window.dispatchEvent(new CustomEvent(SERIES_PLAN_JOB_EVENT, { detail: { job: null, episodeId } }))
}

export function getAgentSeriesPlanJob(): SeriesJobStatus | null {
return requestedSeriesPlanJob
}

export function listenForAgentSeriesPlanJob(
listener: (job: SeriesJobStatus | null, episodeId: string) => void,
): () => void {
const handler = (event: Event) => {
const detail = (event as CustomEvent<{ job?: SeriesJobStatus | null; episodeId?: string }>).detail
if (detail?.episodeId) listener(detail.job || null, detail.episodeId)
}
window.addEventListener(SERIES_PLAN_JOB_EVENT, handler)
if (requestedSeriesPlanJob) listener(requestedSeriesPlanJob, requestedSeriesPlanJob.episodeId)
return () => window.removeEventListener(SERIES_PLAN_JOB_EVENT, handler)
}

export function notifyAgentSeriesRenderJob(job: SeriesJobStatus): void {
requestedSeriesRenderJob = job
window.dispatchEvent(new CustomEvent(SERIES_RENDER_JOB_EVENT, { detail: { job } }))
}

export function getAgentSeriesRenderJob(): SeriesJobStatus | null {
return requestedSeriesRenderJob
}

export function listenForAgentSeriesRenderJob(listener: (job: SeriesJobStatus) => void): () => void {
const handler = (event: Event) => {
const job = (event as CustomEvent<{ job?: SeriesJobStatus }>).detail?.job
if (job) listener(job)
}
window.addEventListener(SERIES_RENDER_JOB_EVENT, handler)
if (requestedSeriesRenderJob) listener(requestedSeriesRenderJob)
return () => window.removeEventListener(SERIES_RENDER_JOB_EVENT, handler)
}

export function notifyAgentSeriesAssemblyJob(job: SeriesAssemblyJob): void {
requestedSeriesAssemblyJob = job
window.dispatchEvent(new CustomEvent(SERIES_ASSEMBLY_JOB_EVENT, { detail: { job } }))
}

export function getAgentSeriesAssemblyJob(): SeriesAssemblyJob | null {
return requestedSeriesAssemblyJob
}

export function listenForAgentSeriesAssemblyJob(listener: (job: SeriesAssemblyJob) => void): () => void {
const handler = (event: Event) => {
const job = (event as CustomEvent<{ job?: SeriesAssemblyJob }>).detail?.job
if (job) listener(job)
}
window.addEventListener(SERIES_ASSEMBLY_JOB_EVENT, handler)
if (requestedSeriesAssemblyJob) listener(requestedSeriesAssemblyJob)
return () => window.removeEventListener(SERIES_ASSEMBLY_JOB_EVENT, handler)
}

export function openAgentSeriesReviewView(view: AgentSeriesReviewView): void {
requestedSeriesReviewView = view
window.dispatchEvent(new CustomEvent(SERIES_REVIEW_VIEW_EVENT, { detail: { view } }))
}

export function listenForAgentSeriesReviewView(listener: (view: AgentSeriesReviewView) => void): () => void {
const handler = (event: Event) => {
const view = (event as CustomEvent<{ view?: AgentSeriesReviewView }>).detail?.view
if (view) listener(view)
}
window.addEventListener(SERIES_REVIEW_VIEW_EVENT, handler)
if (requestedSeriesReviewView) listener(requestedSeriesReviewView)
return () => window.removeEventListener(SERIES_REVIEW_VIEW_EVENT, handler)
}

const ACTIVITY_DETAILS_EVENT = 'hocuspocus:activity-details'
let requestedActivityDetails = false

export function openAgentActivityDetails(): void {
requestedActivityDetails = true
window.dispatchEvent(new CustomEvent(ACTIVITY_DETAILS_EVENT))
}

export function listenForAgentActivityDetails(listener: () => void): () => void {
const handler = () => listener()
window.addEventListener(ACTIVITY_DETAILS_EVENT, handler)
if (requestedActivityDetails) listener()
return () => window.removeEventListener(ACTIVITY_DETAILS_EVENT, handler)
}
export * from '../../lib/uiBus'
2 changes: 1 addition & 1 deletion ui/src/features/series/SeriesEpisodePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { Pill, SectionCard, SeriesField } from './components'
import { SeriesEpisodeProposalReview } from './SeriesEpisodeProposalReview'
import { inputClass, primaryButton, secondaryButton, textareaClass } from './styles'
import type { SeriesEpisode, SeriesJobStatus, SeriesProject } from './types'
import { listenForAgentSeriesPlanJob } from '../agent/agentUiBus'
import { listenForAgentSeriesPlanJob } from '../../lib/uiBus'

export function SeriesEpisodePanel({
workspace, series, episode, updateEpisode, saveNow, reload,
Expand Down
2 changes: 1 addition & 1 deletion ui/src/features/series/SeriesLabPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { SeriesReviewPanel } from './SeriesReviewPanel'
import { Pill } from './components'
import { primaryButton, secondaryButton } from './styles'
import type { SeriesJobStatus, SeriesProject } from './types'
import { listenForAgentSeriesRenderJob, listenForAgentSeriesSection } from '../agent/agentUiBus'
import { listenForAgentSeriesRenderJob, listenForAgentSeriesSection } from '../../lib/uiBus'

type LabTab = 'setup' | 'canon' | 'episode' | 'shots' | 'review'
const tabs: Array<{ id: LabTab; label: string }> = [
Expand Down
2 changes: 1 addition & 1 deletion ui/src/features/series/SeriesReviewPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { Pill, SectionCard } from './components'
import { SeriesShotDurationControl } from './SeriesShotDurationControl'
import { greenButton, primaryButton, secondaryButton } from './styles'
import type { SeriesAssemblyJob, SeriesEpisode, SeriesJobStatus, SeriesProject, SeriesRenderAttempt, SeriesShot } from './types'
import { listenForAgentSeriesAssemblyJob, listenForAgentSeriesReviewView } from '../agent/agentUiBus'
import { listenForAgentSeriesAssemblyJob, listenForAgentSeriesReviewView } from '../../lib/uiBus'

function AttemptPreview({ series, attempt, approved, onApprove, onReject }: {
series: SeriesProject; attempt: SeriesRenderAttempt; approved: boolean; onApprove: () => void; onReject: () => void
Expand Down
2 changes: 1 addition & 1 deletion ui/src/features/stories/StoryLabPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import type {
} from './types'
import type { AspectRatio, ModelOptions, ResolutionPreset } from '../../types'
import { ACE_STEP_MUSIC_MODEL, isAceStepMusicModel, normalizeStoryMusicModel, songWriteTarget } from './musicModel'
import { listenForAgentStoryDraft, listenForAgentStorySection, listenForAgentStoryVisualGeneration } from '../agent/agentUiBus'
import { listenForAgentStoryDraft, listenForAgentStorySection, listenForAgentStoryVisualGeneration } from '../../lib/uiBus'

const button = 'inline-flex items-center justify-center gap-1.5 rounded-md border border-border bg-bg-tertiary px-2.5 py-1.5 text-xs text-text-secondary hover:text-text-primary hover:bg-bg-hover disabled:opacity-40 disabled:cursor-not-allowed transition-colors'
const input = 'w-full rounded-md border border-border bg-bg-tertiary px-2 py-1.5 text-xs text-text-primary focus:outline-none focus:border-accent-blue'
Expand Down
Loading