fix(cut-paper): lipsync Hocus de Tijeral con las voces Qwen - #407
Merged
Conversation
Visemes follow word times from POST /api/v1/audio/analyze on the Qwen WAVs (aligned-audio), then Video 2.5D Export MP4 mixes those tracks. Mouths no longer hold open for the old 6–10 s script slots.
PR Review — Loreframe StudioRisk: medium Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 63.8/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
Cutout planning no longer treats consonants as silence or shuts short Whisper words for half their duration. Aligned-audio beats stay open during speech. Tijeral ships Spanish and English scripts, WAVs, and Video 2.5D shots (shots/ vs shots/en/).
A zero-length closed viseme shared a timestamp with the first spoken word. rebuild kept the later open frame, so evaluateSceneLayer held that viseme from t=0 (Nilo open for 6s, Berta for 17s). Rest closed now starts at t=0. Detect-from-audio no longer applies a dummy plan when every Whisper unit is empty. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Las bocas de Tijeral empezaban a hablar antes de la primera palabra y el ritmo de letras no seguía bien las voces Qwen. Los planos ahora usan intervalos del análisis de audio de Hocus, con la boca cerrada en las pausas y un visema por palabra.
Incluye íntegramente #408. La revisión añade ordenación y límites de tiempo para los intervalos editados, evita extender palabras cortas dentro del silencio y conserva la primera palabra en t=0 cuando el personaje vuelve a hablar después de otro. Un análisis vacío o fuera de la escena no sustituye las bocas existentes. Los planos ingleses usan sus propias voces y tiempos; Story Lab conserva el idioma español de su capítulo predeterminado.
Validación: suite completa de UI en GitHub Actions (1727 pruebas); en local, 26 pruebas dirigidas del código final, lint, tipos, build, traducciones, presupuesto de bundle, guard de repositorio y ratchet contra
60e867a6. Los diez WAV originales coinciden con las duraciones declaradas, con tolerancia de redondeo de 1 ms. Regenerar los JSON públicos desde el compilador no produce cambios adicionales. No se ha rehecho ni escuchado una exportación de Tijeral durante esta revisión.La base anterior provocaba el fallo de complejidad al comparar también cambios ya integrados por #404. Actualizada con
development; el ratchet pasa sin cambiar presupuestos ni baselines. HEAD validado:e72c493436797b347702f29fc3573c2255f7f01b. Todas las GitHub Actions correctas, incluidoCI required, E2E Chromium y speech Windows: CI del HEAD. Las dos automatizaciones de Cursor finalizaron correctamente; el check formal opcionalIndependent QApermanece neutral, no certificado. Preparado para integrar en development; no mezclado en development.