test: freeze Agent Mode capability ports (Paso 3 gate) - #36
Merged
Conversation
Gate for Paso 3 without moving domain logic. Names the current useStore.setState allowlist, slice→agent UI-bus imports, legacy capability executors, and the agentActions/labActions module graph so later slice PRs must shrink those lists instead of growing them.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a6995ce. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Gate de arquitectura para el Paso 3, equivalente al muro WanGP / freeze de providers: solo tests, sin mover lógica.
Nuevo
ui/tests/agentCapabilityPorts.test.mjs:useStore.setStateenfeatures/agent/**fuera deapplicationAdapters.ts(stageStoryVideo3,stageStoryMusicVideo2,cancelCanonicalQueueTask,resumeCanonicalQueueTask,authoritativeWorkspaces).features/agent, salvo los 4 listeners actuales deagentUiBusen Story/Series.context.adapters.*. Congela las 25 executors legacy (Studio bridge, cola, workspaces, Video Editor aux, canciones alternativas,generate_comic_panel,update_character_kit).agentActions.tsylabActions.ts. Cualquier PR de slice posterior debe encoger estas listas, no crecerlas.Por qué ahora
La primera ola ya está en
main(f373667).npm testpasa 443. Este PR no toca hotspots (agentActions.ts/labActions.ts/useStore.ts/ launch).No implementa un quinto objeto
ActionContext. El contrato común ya existe (WizardContextSnapshot,CommandEnvelope,CommandResult,WizardPendingQuestion) y hay que revisarlo antes de trocear dominio.No hace
Verificación local
npx tsx --tsconfig tsconfig.app.json --test tests/agentCapabilityPorts.test.mjs— 4 passnpm testenmain— 443 pass (precondición D7)npm run test:e2eenmain— boot + Story Lab simulada, 2 passstash@{0}e2e wip,stash@{1}compositor 3DDueño del merge: humano. No auto-merge.
Note
Low Risk
Test-only change; it enforces boundaries on future PRs but does not alter runtime behavior.
Overview
Adds
ui/tests/agentCapabilityPorts.test.mjs, a Paso 3 architecture gate with four static checks and no production or refactor changes.The suite freezes today’s Agent Mode “ports”: 8
useStore.setStatecall sites outsideapplicationAdapters.ts, 4 cross-slice imports ofagentUiBusonly, 25 legacy capability executors that do not usecontext.adapters, and the import graphs ofagentActions.tsandlabActions.ts. Failures report added vs removed drift so later slice PRs must shrink allowlists, not grow them.One test loads
capabilityRegistryunder JSDOM and asserts 73 registered capabilities total.Reviewed by Cursor Bugbot for commit a6995ce. Configure here.