Skip to content

test: freeze MiniMax and maestro provider ternaries - #32

Merged
IAnMove merged 1 commit into
mainfrom
test/freeze-provider-ternaries
Sep 1, 2026
Merged

test: freeze MiniMax and maestro provider ternaries#32
IAnMove merged 1 commit into
mainfrom
test/freeze-provider-ternaries

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Alcance

Paso 6.a del plan canónico. Solo tests/gates. Cero refactor de providers y cero cambio de comportamiento.

Cifras medidas en origin/main (9d2b935):

  • === 'minimax' ? bajo ui/src: 30
  • writingProvider === 'maestro' bajo ui/src: 6

El gate alarma si suben. Bajarlas queda para 6.b al tocar esa Lab.

Archivos

  • tests/test_provider_ternary_freeze.py
  • ui/tests/providerTernaryFreeze.test.mjs

Tests locales

  • pytest tests/test_provider_ternary_freeze.py → 2 passed
  • ui/tests/providerTernaryFreeze.test.mjs → 2 passed

Independencia

No toca _launch_runtime.py, director_pipeline.py, ui/src/api/client.ts ni el PR del muro WanGP. No mezclar.


Note

Low Risk
Test-only guards with fixed literal caps; no production code or auth/data paths touched.

Overview
Adds regression gates only (canonical plan step 6.a): no provider refactor and no runtime/UI behavior changes.

New pytest (tests/test_provider_ternary_freeze.py) and Node (ui/tests/providerTernaryFreeze.test.mjs) suites scan all .ts/.tsx under ui/src and fail if counts rise above baselines from origin/main30 for === 'minimax' ? and 6 for writingProvider === 'maestro'. Failure messages steer contributors toward provider_profile / writingProviderFromText instead of new inline ternaries.

Reviewed by Cursor Bugbot for commit 300b3a6. Configure here.

Paso 6.a of the architecture plan. Measure-only gate: 30 `=== 'minimax' ?`
and 6 `writingProvider === 'maestro'` under ui/src. Alarm if they grow.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 2 file(s); +81/-0

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: tests/test_provider_ternary_freeze.py, ui/tests/providerTernaryFreeze.test.mjs

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 300b3a6. Configure here.

@IAnMove
IAnMove merged commit 71960b0 into main Sep 1, 2026
5 checks passed
@IAnMove
IAnMove deleted the test/freeze-provider-ternaries branch September 5, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant