test: freeze MiniMax and maestro provider ternaries - #32
Merged
Conversation
Paso 6.a of the architecture plan. Measure-only gate: 30 `=== 'minimax' ?` and 6 `writingProvider === 'maestro'` under ui/src. Alarm if they grow.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 300b3a6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alcance
Paso 6.a del plan canónico. Solo tests/gates. Cero refactor de providers y cero cambio de comportamiento.
Cifras medidas en
origin/main(9d2b935):=== 'minimax' ?bajoui/src: 30writingProvider === 'maestro'bajoui/src: 6El gate alarma si suben. Bajarlas queda para 6.b al tocar esa Lab.
Archivos
tests/test_provider_ternary_freeze.pyui/tests/providerTernaryFreeze.test.mjsTests locales
pytest tests/test_provider_ternary_freeze.py→ 2 passedui/tests/providerTernaryFreeze.test.mjs→ 2 passedIndependencia
No toca
_launch_runtime.py,director_pipeline.py,ui/src/api/client.tsni el PR del muro WanGP. No mezclar.Note
Low Risk
Test-only guards with fixed literal caps; no production code or auth/data paths touched.
Overview
Adds regression gates only (canonical plan step 6.a): no provider refactor and no runtime/UI behavior changes.
New pytest (
tests/test_provider_ternary_freeze.py) and Node (ui/tests/providerTernaryFreeze.test.mjs) suites scan all.ts/.tsxunderui/srcand fail if counts rise above baselines fromorigin/main—30 for=== 'minimax' ?and 6 forwritingProvider === 'maestro'. Failure messages steer contributors towardprovider_profile/writingProviderFromTextinstead of new inline ternaries.Reviewed by Cursor Bugbot for commit 300b3a6. Configure here.