fix(wizard): preservar texto de escena y órdenes reales de cancelar/reintentar - #293
Open
cursor[bot] wants to merge 3 commits into
Open
fix(wizard): preservar texto de escena y órdenes reales de cancelar/reintentar#293cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Quoted cancel/retry language inside an explicit generate command was matching cancel_task / retry_task first and killing or relaunching the active GPU job instead of enqueueing the requested video or image. Treat a Studio generation command as generation, not cancel/retry. Keep standalone cancel the generation and retry the failed job as commands. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
PR Review — Loreframe StudioRisk: medium Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 58.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
…nt-review-20260910
25 tasks
IAnMove
marked this pull request as ready for review
September 9, 2026 23:03
Author
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_5d3dc609-500f-42fa-98da-adf1e493bfd4) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen ejecutivo
Qué cambia
El Wizard distingue las palabras de un cartel o diálogo de las órdenes de cancelar/reintentar. Un reintento explícito conserva su tarea original aunque el mensaje también describa la imagen que debe generar.
Para qué sirve
El hallazgo de Cursor era real: «Generate a video of a director yelling stop the video» podía cancelar otro trabajo. Su primera solución daba prioridad a cualquier mención de generación y rompía un reintento real de Flux ya cubierto por la suite completa.
Impacto para el usuario
Los textos literales permanecen intactos. Las órdenes explícitas de cancelar/reintentar, incluidas las que aparecen en otra frase, mantienen su identificador de tarea y no se convierten en una generación nueva.
Riesgo
Estado
Summary
Fix task-word hijacking without giving generation unconditional priority across an entire message. Keep current development's #291 capability guards. Inspect task controls per clause; mask quoted content only in a derived classification view of a generation request. Leading task commands and explicit controls in another sentence retain the existing task precedence.
Overview
A generation clause describing a director saying
stop the videoremains generation. Quoted scene text can contain punctuation without creating task commands.Retry the failed image task. Create an image of a lighthouse.retains itsretry_taskand exact task ID. An explicit cancellation in another sentence remains a cancellation.Detailed changes
Backend
No task/queue/retry endpoint changes.
UI and Wizard
Data, provenance and compatibility
Existing task IDs, prompts and proposals are retained. Current how-to guards remain in place. No schema, workspace, persistence or model changes.
Files and ownership
ui/src/features/agent/agentActions.tsui/tests/agentActions.test.mjswizardTurnReport.test.tsremains unchanged and must pass.Validation
bde8a3b6d01c2ccbdd71a45f83cf8f474713c8dd(development).8677f248b39dcd58592f8a6ab024c9fcb9609510.CI and review
CI requiredand both Cursor automations SUCCESS. Formal Independent QA and Cursor Bugbot NEUTRAL are not approvals.Notes and limitations
This remains a bounded EN/ES intent heuristic. It does not certify arbitrary prose, all quotation syntaxes or every same-sentence compound command. Separate explicit task-control clauses retain the existing precedence instead of launching extra work. The change fixes the reported literal-scene cases and preserves the real retry fixture rather than weakening it.