fix(studio): no lanzar la GPU desde la pestaña Mixer - #292
Open
cursor[bot] wants to merge 3 commits into
Open
Conversation
El enrutado de comandos compartidos solo admite speech/music/sfx. Mixer caía al submitGeneration legado con el model_type y el prompt del tab anterior, así que Generate arrancaba una generación de Voz/Música/SFX. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 58.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
IAnMove
marked this pull request as ready for review
September 9, 2026 23:01
Author
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_120a77d2-fe6e-4e8c-a785-253e64849593) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen ejecutivo
Qué cambia
Audio → Mixer oculta Generate y rechaza las llamadas a generación antes de crear un trabajo. Mixer conserva sus acciones propias de mezclar audio.
Para qué sirve
Evita que los ajustes conservados de Speech/Music/SFX se envíen desde Mixer al endpoint de generación. El hallazgo de Cursor era real; su CI fallaba porque el test nuevo importa el store y esa dependencia no estaba registrada.
Impacto para el usuario
Cambiar al mezclador no permite lanzar accidentalmente el modelo anterior. Voz, Música y SFX conservan sus comandos tipados.
Riesgo
Estado
Summary
Keep the original Mixer guard and refresh the branch on current development. Register only the new
studioSubmissionFailure.test.ts→useStore.tsbehavioral dependency in the architecture wire inventory. The existing architecture assertion remains unchanged.Overview
The Sidebar hides Generate in Mixer.
startGenerationrejects Mixer before scheduling or adding a job. Studio submission rejects missing/unknown/non-generative Audio submodes instead of falling through to legacy model generation. Speech/Music/SFX and image use their existing typed gateways; video keeps its current native path.Detailed changes
Backend
No runtime changes. The inventory adds one verified behavioral test dependency, not a regenerated baseline or a new exemption.
UI and Wizard
Keep the translated EN/ES refusal, early store guard, submission fallback guard and hidden Mixer Generate button. Mix & Save remains handled by Mixer controls.
Data, provenance and compatibility
No model, command schema, sidecar or persistence changes. The guards operate at the Studio UI/store submission boundary; this does not introduce a new server-side Mixer API.
Files and ownership
useStore.startGeneration.studioSubmissionFailure.test.tsand one architecture inventory entry.Validation
bde8a3b6d01c2ccbdd71a45f83cf8f474713c8dd(development, includes test(studio): proteger referencias Music con voces Speech guardadas #283/fix(wizard): consultas de cancelar/reintentar sin perder textos literales #291).0abf34f42810d99a907698340f6cd2d24f4bf750.CI and review
CI requiredand both Cursor automations SUCCESS. Formal Independent QA and Cursor Bugbot NEUTRAL are not approvals.Notes and limitations
Mixer refusal is distinct from audio mixing. Missing/unknown Audio submodes fail closed during preparation; this does not change Mixer mixing/render quality or promise new media validation.